Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65562
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <op.wrvtgw0hidpuyk@damnation.nl.lo.geleia.net>
References: <CAESVnVrUaVjQvFAGqqFm=8oGV2YXXgGFm7GT3QpaQLAoL_J_oQ@mail.gmail.com>
 <op.wrvtgw0hidpuyk@damnation.nl.lo.geleia.net>
Date: Sat, 2 Feb 2013 12:11:19 -0200
Message-ID: <CA+5g0S+2CdHzBPX4mvV6mwPmbNBTSDmZLHX+AA5rKhXbp8TrRA@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: PHP internals <internals@lists.php.net>, Sara Golemon <pollita@php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: Non-pointer params, zend_parse_parameters, and the
 "!" modifier
From: felipensp@gmail.com (Felipe Pena)

2013/2/2 Gustavo Lopes <glopes@nebm.ist.utl.pt>:
> On Sat, 02 Feb 2013 14:36:00 +0100, Sara Golemon <pollita@php.net> wrote:
>
>> Gustavo's diff for scalars adds '!' support (this was ignored
>> previously) by letting the NULL get cast to the type (e.g.
>> false/0/0.0) and using a second zend_bool parameter to indicate if
>> NULL was passed or not:
>>
>>   long num = 42;
>>   zend_bool num_was_null;
>>
>>   if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l!", &num,
>> &num_was_null) == FAILURE) return;
>>
>> Now if the func is called with NULL as the argument, num will still be
>> overwritten to 0, but we'll get the flag indicating that NULL got
>> passed in, and we're forced to reset it to the default value (assuming
>> that was our intent).
>>
>> [...]
>> Thoughts?
>
>
> You raise a good point. From my part, feel free to modify it so the passed
> long is not changed.
>

Yeah, makes sense. +1

-- 
Regards,
Felipe Pena