Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65561
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.22 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "PHP internals" <internals@lists.php.net>, "Sara Golemon"
 <pollita@php.net>
References: <CAESVnVrUaVjQvFAGqqFm=8oGV2YXXgGFm7GT3QpaQLAoL_J_oQ@mail.gmail.com>
Date: Sat, 02 Feb 2013 15:06:22 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.wrvtgw0hidpuyk@damnation.nl.lo.geleia.net>
In-Reply-To: <CAESVnVrUaVjQvFAGqqFm=8oGV2YXXgGFm7GT3QpaQLAoL_J_oQ@mail.gmail.com>
User-Agent: Opera Mail/12.12 (Linux)
Subject: Re: Non-pointer params, zend_parse_parameters, and the "!" modifier
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Sat, 02 Feb 2013 14:36:00 +0100, Sara Golemon <pollita@php.net> wrote:

> Gustavo's diff for scalars adds '!' support (this was ignored
> previously) by letting the NULL get cast to the type (e.g.
> false/0/0.0) and using a second zend_bool parameter to indicate if
> NULL was passed or not:
>
>   long num = 42;
>   zend_bool num_was_null;
>
>   if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l!", &num,
> &num_was_null) == FAILURE) return;
>
> Now if the func is called with NULL as the argument, num will still be
> overwritten to 0, but we'll get the flag indicating that NULL got
> passed in, and we're forced to reset it to the default value (assuming
> that was our intent).
>
> [...]
>Thoughts?

You raise a good point. From my part, feel free to modify it so the passed  
long is not changed.

-- 
Gustavo Lopes