Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65093
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50FECA4E.6080408@lerdorf.com>
References: <50F840F4.7080704@zerocue.com>
	<50FE7579.1010409@zerocue.com>
	<50FECA4E.6080408@lerdorf.com>
Date: Tue, 22 Jan 2013 20:41:25 +0100
Message-ID: <CAF+90c9ZdhMOWZrVPMextovO64i1UM48P8==CRpruzn9Wg8UaQ@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Clint Priest <cpriest@zerocue.com>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec54ee290643e5c04d3e5c3b2
Subject: Re: [PHP-DEV] [VOTE] Property Accessors for 5.5
From: nikita.ppv@gmail.com (Nikita Popov)

--bcaec54ee290643e5c04d3e5c3b2
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Jan 22, 2013 at 6:20 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> The simple explanation from me is that the ROI isn't there on this one.
> It adds a lot of code complexity for very little return. Yes, it saves a
> couple of lines of boilerplate code for a few people, but the cost is
> high in terms of ongoing maintenance and potential issues for opcode
> caches as well. If you look at the split in voting you will notice it is
> pretty much split along the lines of the people who have to maintain
> this code vs. the people who would like a shiny new feature.
>

I did a bit of testing with APC today and here is what I came up with:
https://gist.github.com/4597660 It adds the logic for copying the accessor
functions in my_copy_property_info*. This seemed to do the trick in my
testing, but I don't really know APC, so I can't judge whether it might
require further changes.

Thanks,
Nikita

--bcaec54ee290643e5c04d3e5c3b2--