Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65057
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <op.wq9ysboiidpuyk@damnation.nl.lo.geleia.net>
References: <CAF+90c_Aa0TW9WfY8q5=RnSnAwC+8u6J+Ywp-i0+d21TTn8eJw@mail.gmail.com>
	<op.wq9ysboiidpuyk@damnation.nl.lo.geleia.net>
Date: Mon, 21 Jan 2013 14:28:12 -0500
Message-ID: <CAAyV7nH1WutviwMBQ75Kr4C3kEdipcEMhGkobLVNyXtsdKgpBA@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: PHP internals <internals@lists.php.net>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=20cf307f380a3f666704d3d176dd
Subject: Re: [PHP-DEV] [VOTE] Alternative typehinting syntax for accessors
From: ircmaxell@gmail.com (Anthony Ferrara)

--20cf307f380a3f666704d3d176dd
Content-Type: text/plain; charset=ISO-8859-1

Gustavo

I've voted "No" due to concerns I mentioned in most part in IRC, but which
> I think should be here on the record. So my voting statement:
>
> I'm voting against this proposal because I think the proposed syntax
> strongly suggests that the property is bound to a specific type. This has
> several problems:
>
> * It's a promise that's not guaranteed. As long as the getter is allowed
> to reference the value of the variable can arbitrarily be changed to
> whatever type. It may also be possible to do the same with unserialization.
>

This is pretty easily solved by removing the ability to return a reference
from the getter when the shortcut syntax is used. In fact, remove the
ability to set the body of a getter at all (it would only allow you to
specify the visibility. If you need references, you can't use this syntax...


> * The benefits are minimal. The only real benefit is cutting maybe two
> lines of code in an indisputably common scenario.
>

Cutting two lines of code per instance. And considering that this is used
all the time, that can add up to some pretty significant (if not trivial)
boilerplate that's removed...


Anthony

--20cf307f380a3f666704d3d176dd--