Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65032
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADyq6s+zU5f23y63EveMOAF0KfZfDM5mk0-SmMNjGDe__HPNFw@mail.gmail.com>
References: <CAFnjAVzjBYnP1G1MajHDinEAr4BuCJS_C5XS4PgTZ9iirYvOHw@mail.gmail.com>
	<3F59B8D4-01A9-4B97-89D0-4DC21B58F1C0@php.net>
	<CAKxcST9jLkOVCapW4+4bjWuj-1E8rLM72JNZJ3xV8DwPwi_1zg@mail.gmail.com>
	<CAFnjAVxX7YPWG_4M1iu7rtPRo4BrCDHQd5jq-6LrPXkNG6Hy1w@mail.gmail.com>
	<CAKxcST9wGWwBqHN4JabSA4=3mA9RuSbE_OXd+U0P2hLYM+dMtQ@mail.gmail.com>
	<CAFnjAVwSqA6TTOpkfh5phe73DTgi37v=Wdk2jKKMO0bm-VC-1w@mail.gmail.com>
	<CADyq6s+zU5f23y63EveMOAF0KfZfDM5mk0-SmMNjGDe__HPNFw@mail.gmail.com>
Date: Fri, 18 Jan 2013 18:44:44 +0300
Message-ID: <CAFnjAVwEKDtXE=wuv0VLBKeN2RerbAT+ow_enoabout0LX8G9A@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Paul Dragoonis <dragoonis@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04374581896e6004d391fdc6
Subject: Re: [PHP-DEV] new FTP function
From: wowkise@gmail.com (KISE)

--f46d04374581896e6004d391fdc6
Content-Type: text/plain; charset=ISO-8859-1

hello Marco Pivetta,

while the implementations you linked indeed works, it also kinda big and
involve changing the error handler just so that it doesn't show the error,
which i think is not the way to do it. i think there should be simple way
to check like "is_dir" or "is_file".

anyway thanks for the hints, i have sent request to bugs.php.net, and i
dont like to spam the dev list since they quite busy already

PS: and sorry for the grammar errors, English is not my native tongue.


On Fri, Jan 18, 2013 at 6:37 PM, Marco Pivetta <ocramius@gmail.com> wrote:

> Heya KISE,
>
> I just checked a bit around and found that current implementations
> actually simply deal with the warning:
>
>
> https://github.com/rjkip/ftp-php/blob/master/src/FtpPhp/FtpClient.php#L172-L186
>
> https://github.com/rjkip/ftp-php/blob/master/src/FtpPhp/FtpClient.php#L92-L116
>
> What kind of problems is the warning currently causing in your code?
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
>
> On 18 January 2013 16:33, KISE <wowkise@gmail.com> wrote:
>
>> Paul Dragoonis,
>>
>> Actually it wont work i did tried it before, if the dir end with / it will
>> list the directories inside the path you gave it and if it doesn't have
>> any
>> directories it will return false since there is no directories to return.
>>
>> you have to take out the last / and then remove the directory in question
>> and list the files in the parent directory and check if the dir exists
>> otherwise it will return false, i spent 3hrs yesterday thinking why its
>> returning false even though the directory exists.
>>
>> On Fri, Jan 18, 2013 at 6:28 PM, Paul Dragoonis <dragoonis@gmail.com>
>> wrote:
>>
>> >
>> > On Fri, Jan 18, 2013 at 3:18 PM, KISE <wowkise@gmail.com> wrote:
>> >
>> >>         $res  = ftp_nlist($this->conn_id, '-dF '. $dir);
>> >>
>> >
>> > This could be done in two lines.
>> >
>> > function dir_exists($conn, $dir) {
>> >         $list  = ftp_nlist($conn, '-dF '. $dir);
>> >         return in_array($dir, $list);
>> > }
>> >
>>
>
>

--f46d04374581896e6004d391fdc6--