Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64993
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50F3BFBA.9070701@sugarcrm.com>
References: <50F3BFBA.9070701@sugarcrm.com>
Date: Wed, 16 Jan 2013 11:57:06 +0300
Message-ID: <CA+9eiLtVtJ-E-Rf16Z99z+jhFBXKF3G5_kK=WrMDFFEA6Cm4Ag@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8ff1c2c212bf2804d3641056
Subject: Re: Fix for duplicate magic methods calls (bug #63462)
From: dmitry@zend.com (Dmitry Stogov)

--e89a8ff1c2c212bf2804d3641056
Content-Type: text/plain; charset=UTF-8

Hi Stas,

I think the patch is correct and should be committed into 5.3 and above.

Thanks. Dmitry.

On Mon, Jan 14, 2013 at 12:20 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> I made a fix for bug #63462 - https://github.com/php/php-src/pull/258 -
> which changes a bit how we do guards by unmangling the names before
> applying guards. This is a slight change of behavior and also means that
> all private vars with the same name would use the same guard (all
> protected and public vars with the same name are the same var anyway, so
> they should be doing it in any case).
> Since it's a behavior change in core, I'd appreciate a second pair of
> eyes to see if nothing is broken by it. All tests pass but better safe
> then sorry. If no problems found in it, I'll commit it soon.
>
> Thanks,
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>

--e89a8ff1c2c212bf2804d3641056--