Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64947
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.175 as permitted sender)
MIME-Version: 1.0
Sender: sebastian.krebs.berlin@gmail.com
In-Reply-To: <CAEbg-4b=t+H63NwcK=6vCNhKUET7FmzmFkFXdEKCgYGfUo7Xxw@mail.gmail.com>
References: <CAEbg-4Z+iUyaVjbQBVkB3RLzF8CAHBq+qA29AXJFt+Kw_pGn5A@mail.gmail.com>
	<CALtuQzAi27mF2-5JzFixbOcM6GBK7fp2Z0FWVd-kSBewz=Z+ZA@mail.gmail.com>
	<CAEbg-4b=t+H63NwcK=6vCNhKUET7FmzmFkFXdEKCgYGfUo7Xxw@mail.gmail.com>
Date: Mon, 14 Jan 2013 20:53:38 +0100
Message-ID: <CALtuQzAQFnKpFOEvJmCPgCGGN=j-dyx4+NKX_A9xEZ3ff8PjCw@mail.gmail.com>
To: Alexander Lissachenko <lisachenko.it@gmail.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0141a0025b40ff04d345003d
Subject: Re: [PHP-DEV] [Reflection] Improve logic of ReflectionMethod->invokeArgs()
 for static methods
From: krebs.seb@gmail.com (Sebastian Krebs)

--089e0141a0025b40ff04d345003d
Content-Type: text/plain; charset=ISO-8859-1

2013/1/14 Alexander Lissachenko <lisachenko.it@gmail.com>

> My use-case is weaving aspects into the methods. Yeah! )
>
> So, I take the original class, rename it and then create a decorator
> class instead of original class with overridden dynamic and static
> methods. Method in the decorator should make some specific logic and
> then just invokes the original static method with Reflection, but the
> scope should be also correct.
>
> For example, previous class First will be renamed during load-time to
> the First_AopProxied:
>
> class First_AopProxied
> {
>     public static function foo()
>     {
>         echo get_called_class();
>     }
> }
>
> and decorator will be created
>
> class First extends First_AopProxied
> {
>     public static function foo()
>     {
>         // some logic here, that should call parent method and
> preserve the scope (class First)
>         // can not use parent::foo() here, because around advice
> should be able to call this method somewhere in the closure...
>     }
> }
>

I must say this example is not really better than the last one (it feels
like it is exactly the same with 2 lines more comments). Also I don't know,
what you mean by "call this method somewhere in the closure"; which
closure?!?
I guess you are in fact looking for regular instance methods.


>
> 2013/1/14 Sebastian Krebs <krebs.seb@gmail.com>:
> >
> >
> >
> > 2013/1/14 Alexander Lissachenko <lisachenko.it@gmail.com>
> >>
> >> Hi! It's my first letter here )
> >>
> >> I want to suggest a small improvement for ReflectionMethod->invoke()
> >> and ReflectionMethod->invokeArgs() methods to support LSB for
> >> overridden static methods. Currently, for invoking static methods
> >> first argument should be null, information about class (scope) is
> >> taken from the reflection class. However, there is one issue that can
> >> not be solved at the current time.
> >>
> >> Suppose, we have two classes:
> >>
> >> class First
> >> {
> >>     public static function foo()
> >>     {
> >>         echo get_called_class();
> >>     }
> >> }
> >>
> >> class Second extends First
> >> {
> >>     public static function foo()
> >>     {
> >>         echo "Do not call me, please";
> >>     }
> >> }
> >>
> >> Now I want to invoke the First::foo() method with Reflection from the
> >> Second class scope for using LSB. Currently this is impossible:
> >> $class = new ReflectionClass('First');
> >> $class->getMethod('foo')->invokeArgs(null, array()); // Outputs
> >> 'First' as no scope information is passed
> >>
> >>
> >> $class = new ReflectionClass('Second');
> >> $class->getMethod('foo')->invokeArgs(null, array()); // Outputs 'Do
> >> not call me, please' as method is redefined
> >>
> >> So, there is no way now to invoke the static First::foo() method from
> >> the child scope because it was redefined. However, this can be easily
> >> implemented by adding the scope for static methods invocation (like
> >> Closure::bindTo()):
> >>
> >> $class = new ReflectionClass('First');
> >> $class->getMethod('foo')->invokeArgs('Second', array()); // Outputs
> >> 'Second'
> >>
> >> This improvement can be very useful for building proxies for static
> >> methods, that use LSB. Can it be implemented for PHP 5.3-5.5? Thanks!
> >
> >
> > Maybe it's just me, but could you explain which use-case want to solve?
> The
> > example isn't very useful, because you can achieve this quite easy
> without
> > reflection. Also why do you override the method, when you don't want it
> to
> > get called? Shouldn't they two separate methods then?
> >
> > <?php
> > class First
> > {
> >     public static function foo()
> >     {
> >         echo get_called_class();
> >     }
> > }
> >
> > class Second extends First
> > {
> >     public static function foo()
> >     {
> >         echo "Do not call me, please";
> >     }
> > public static function bar() {
> > parent::foo();
> > }
> > }
> > Second::bar();
> >
> > http://codepad.viper-7.com/fwG5GB
> >
> >>
> >>
> >> --
> >> PHP Internals - PHP Runtime Development Mailing List
> >> To unsubscribe, visit: http://www.php.net/unsub.php
> >>
> >
> >
> >
> > --
> > github.com/KingCrunch
>



-- 
github.com/KingCrunch

--089e0141a0025b40ff04d345003d--