Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64943
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.51 as permitted sender)
MIME-Version: 1.0
Date: Mon, 14 Jan 2013 23:02:57 +0400
Message-ID: <CAEbg-4Z+iUyaVjbQBVkB3RLzF8CAHBq+qA29AXJFt+Kw_pGn5A@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: [Reflection] Improve logic of ReflectionMethod->invokeArgs() for
 static methods
From: lisachenko.it@gmail.com (Alexander Lissachenko)

Hi! It's my first letter here )

I want to suggest a small improvement for ReflectionMethod->invoke()
and ReflectionMethod->invokeArgs() methods to support LSB for
overridden static methods. Currently, for invoking static methods
first argument should be null, information about class (scope) is
taken from the reflection class. However, there is one issue that can
not be solved at the current time.

Suppose, we have two classes:

class First
{
    public static function foo()
    {
        echo get_called_class();
    }
}

class Second extends First
{
    public static function foo()
    {
        echo "Do not call me, please";
    }
}

Now I want to invoke the First::foo() method with Reflection from the
Second class scope for using LSB. Currently this is impossible:
$class = new ReflectionClass('First');
$class->getMethod('foo')->invokeArgs(null, array()); // Outputs
'First' as no scope information is passed

$class = new ReflectionClass('Second');
$class->getMethod('foo')->invokeArgs(null, array()); // Outputs 'Do
not call me, please' as method is redefined

So, there is no way now to invoke the static First::foo() method from
the child scope because it was redefined. However, this can be easily
implemented by adding the scope for static methods invocation (like
Closure::bindTo()):

$class = new ReflectionClass('First');
$class->getMethod('foo')->invokeArgs('Second', array()); // Outputs 'Second'

This improvement can be very useful for building proxies for static
methods, that use LSB. Can it be implemented for PHP 5.3-5.5? Thanks!