Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64834
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain oracle.com designates 141.146.126.69 as permitted sender)
Message-ID: <50EF4F71.9080701@oracle.com>
Date: Thu, 10 Jan 2013 15:32:01 -0800
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAOg_pRTSGouOVYzorTH1WDYvKqtKdJkJVHxVddO4u=TGNkSs8A@mail.gmail.com> <ce9075c17cad65fcdd350a1f243e6ea1@nebm.ist.utl.pt> <op.wqn1hdywidpuyk@damnation.nl.lo.geleia.net>
In-Reply-To: <op.wqn1hdywidpuyk@damnation.nl.lo.geleia.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] strtr vs. str_replace runtime
From: christopher.jones@oracle.com (Christopher Jones)



On 01/09/2013 02:45 PM, Gustavo Lopes wrote:
> On Thu, 03 Jan 2013 11:40:31 +0100, Gustavo Lopes <glopes@nebm.ist.utl.pt> wrote:
>
>> The algorithm behaves very poorly in this case because at each position of the text, all the substrings starting there and with size between m and n (where m is the size of the smallest pattern and n is the largest) are checked, even if there are only
>> two patterns with size m and n. We could fix this easily by building a set of the pattern sizes found and try only with those. The hashing of the substrings could also be improved; we don't have to recalculate everything when we advance in the text.
>>
>
> Both optimizations (the hash rolling and limiting the substrings hashed on each iteration) worked quite well.
>
> But I got much better results with another algorithm [1], so I'm going to merge the branch with it [2] instead. I get these results with a 1.7 MB string and 13 replacement strings, the smallest with 6 characters and 30 iterations (x86-64, gcc -O3):
>
> strtr: 0.1387
> str_replace: 0.4471
>
> The algorithm doesn't perform as well when the replacement strings are small. Adding a replacement for the pattern '_' (1 character) yields:
>
> strtr: 0.6157
> str_replace: 0.6230

How does this compare with your baseline results?

>
> But even in this case, it works better than my optimized version of the current algorithm.
>
> I plan on merging to 5.4 and 5.5; you may want to review it as introducing completely new code carries some risk.

Depending on the improvement, it might be tempting to merge to 5.4 but I would
prefer to see it in 5.5+.  Let's keep 5.4 stable.

Chris


>
> [1] http://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.13.2927
> [2] https://github.com/cataphract/php-src/compare/strtr_wu94
>

-- 
christopher.jones@oracle.com  http://twitter.com/ghrd
Newly updated, free PHP & Oracle book:
http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html