Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:6476
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Reply-To: ilia@prohost.org
Organization: Prohost.org
To: Moriyoshi Koizumi <moriyoshi@at.wakwak.com>,
 PHP Internals <internals@lists.php.net>
Date: Mon, 15 Dec 2003 11:03:53 -0500
User-Agent: KMail/1.5.4
References: <25BBBBC2-2CD2-11D8-8FCC-000A95CE0C62@at.wakwak.com> <200312151032.28825.ilia@prohost.org> <7E47960A-2F14-11D8-8F76-000A95CE0C62@at.wakwak.com>
In-Reply-To: <7E47960A-2F14-11D8-8F76-000A95CE0C62@at.wakwak.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200312151103.53137.ilia@prohost.org>
Subject: Re: [PHP-DEV] Re: Regarding the latest patch on fgetcsv() (stable branch)
From: ilia@prohost.org (Ilia Alshanetsky)

On December 15, 2003 10:36 am, Moriyoshi Koizumi wrote:
> Well, the legacy users of PHP4 will significantly suffer for
> PHP5's new features.

How so? PHP 5 does break BC (especially for objects) but this is something 
that was talked about for years and the consensus is/was that the change is 
for the better. To my knowledge, majority of the new features in PHP5 are 
just that and have no side effects.

Another alternative to moving fgetcsv()'s current implementation would be to 
add #ifdef HAVE_MBSTRING around php_mblen, which would do 
#define php_mblen(ptr, len) 1
if mbstring is not enabled.

Personally, I'd prefer to have the function in mbstring and modified further 
to support multibyte delimiters and enclosures, which it does not do now due 
to performance considerations.

Ilia