Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64758
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.220.173 cause and error)
Message-ID: <50ED9C46.40103@lerdorf.com>
Date: Wed, 09 Jan 2013 08:35:18 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Derick Rethans <derick@php.net>
CC: Rafael Dohms <listas@rafaeldohms.com.br>, 
 Stas Malyshev <smalyshev@sugarcrm.com>,
 Pierre Joye <pierre.php@gmail.com>, 
 Pierrick Charron <pierrick@webstart.fr>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <CADqTB_h4eh4mPi89uRps6vZWXjDEhUtcBopL7jmO-UgRuyf19w@mail.gmail.com> <50EBDEEE.8070605@sugarcrm.com> <CAOfKkdQXh53oxpCQ59R_hcws4Pd=q+O_VMOZ=tS+F2_7qof3RA@mail.gmail.com> <50EC6569.6030202@sugarcrm.com> <CAEZPtU5gGsr97ZD+ybxgnRj7=X2mtL4+m0qWdYMg1qsgj0+MrA@mail.gmail.com> <50EC917C.3070805@sugarcrm.com> <CAOhuFvZv9ePXkW+6ZDi_w+-Y-PHBLXSXAMdupX0vst8rsQ+L1g@mail.gmail.com> <alpine.DEB.2.02.1301091213310.28951@whisky.home.derickrethans.nl>
In-Reply-To: <alpine.DEB.2.02.1301091213310.28951@whisky.home.derickrethans.nl>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Reflection annotations reader
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 01/09/2013 04:16 AM, Derick Rethans wrote:
> On Tue, 8 Jan 2013, Rafael Dohms wrote:

>> 1. The syntax is crap: this is solvable, let's find the right syntax
> 
> Any extra syntax makes the PHP parser more complicated (and arguably 
> slower). I don't want to have it slower/more complex for some arbitrary 
> extra syntax just for some weird annotations.

This is my worry as well. Especially when it comes to opcode cache
support. Most of the patches I see these days completely ignore the
opcode cache side of things which needs to change. For any large
language-level change, any implementation that doesn't also include an
APC diff, or at least a very complete explanation of how it will be
generally supported by opcode caches just isn't complete.

In this case, attaching annotations/properties to classes will
definitely affect APC since we cache classes separately and NOP their
creation out of the op_arrays. So any extra opcodes will have to be
optimized out and the resulting class created and cached correctly.

-Rasmus