Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64693
Return-Path: <njaguar@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 50817 invoked from network); 8 Jan 2013 16:09:26 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 8 Jan 2013 16:09:26 -0000
Authentication-Results: pb1.pair.com smtp.mail=njaguar@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=njaguar@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
X-PHP-List-Original-Sender: njaguar@gmail.com
X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com  
Received: from [209.85.214.170] ([209.85.214.170:35022] helo=mail-ob0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 53/FC-16636-5B44CE05 for <internals@lists.php.net>; Tue, 08 Jan 2013 11:09:25 -0500
Received: by mail-ob0-f170.google.com with SMTP id wp18so607670obc.29
        for <internals@lists.php.net>; Tue, 08 Jan 2013 08:09:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=0Y3hB3fGnXwpCy6d27P0xNKFq/nXhZFjUccuVF89uOs=;
        b=CAjQEuM+1FwU47fZ1hTWcgFtIMWzSsRBOSAAR1KIqkFTRaviY/0zu3WkLtV6aulIOc
         c7XQRdgb5k3P8g3EKeL4BTDuNXmj0G8TY54IGgGOJRfUtam7mzyMEWZUI0JEUpPscIYt
         Gn41wMpq1Wq+wdihXXhKIKzr54qYpjOtFm4DLF8WFJPO9JLbfGlsjKNTxtHeh0d3eUUN
         iawry+NRUXjUqPjb/oNoZb8oaOFZaW33yFACFyeRehO3FdfV+58/xphPuVInczFX0kgs
         Cr02kqUadgTNO6KcZCAoDmYhjoQULq1c9MZos7g9dR42kGy2ofvIqxBGnfadn+EMnJLh
         +mcg==
MIME-Version: 1.0
Received: by 10.60.32.235 with SMTP id m11mr37278450oei.129.1357661362487;
 Tue, 08 Jan 2013 08:09:22 -0800 (PST)
Received: by 10.182.89.66 with HTTP; Tue, 8 Jan 2013 08:09:22 -0800 (PST)
Date: Tue, 8 Jan 2013 10:09:22 -0600
Message-ID: <CACzKMq2oPUb0HAidUz3R6RjNDGnp1Wdu2BiQcZGejcA9R6SC-g@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Date timezone performance/cleanup [PATCH]
From: njaguar@gmail.com (Paul Taulborg)

https://bugs.php.net/bug.php?id=63941

Per discussion with Nuno Lopes and Christopher Jones, I have created
another patch to simplify guess_timezone() in ext/date/php_date.c

Internals summary: removes the newly patched in int value that caches
whether a timezone was previously checked or not, as well as reduces
complexity by only using timezone for the stored (and checked)
timezone value. default_timezone is still used locally for ini_set()
calls, but is copied to timezone when checked as valid. Does give a
slight performance increase due to less compiled ops.

If anyone has any feedback, let me know.

Thanks in advance!