Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64621
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain webstart.fr from 74.125.82.44 cause and error)
MIME-Version: 1.0
In-Reply-To: <50E90DD1.7040204@sugarcrm.com>
References: <50E90DD1.7040204@sugarcrm.com>
Date: Sun, 6 Jan 2013 23:40:12 -0500
Message-ID: <CAOfKkdTAV9qY_sxzORzhBjH0kRbkJr8XF+sU5eik=SGw582Nng@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] Fixing insecure cURL file uploading
From: pierrick@webstart.fr (Pierrick Charron)

Hi Stas,

Everything looks good to me :) Great job.

About your optional section :

I like the procedural function that you proposed so that you don't
have to use an object if you don't want to.

cURL allow you to upload file from string buffer with CURLFORM_BUFFER
and we should be able to do all the streams stuff with CURLFORM_STREAM
and by modifying our CURLOPT_READFUNCTION.

Pierrick


On 6 January 2013 00:38, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
> Following the recent discussion on the list, I've drafted an RFC
> describing the CurlFile solution for it here:
>
> https://wiki.php.net/rfc/curl-file-upload
>
> Please review and comment. If there's a general positive feedback, I'll
> try to implement a patch for it pretty soon.
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>