Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64601 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96703 invoked from network); 6 Jan 2013 09:39:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Jan 2013 09:39:27 -0000 Authentication-Results: pb1.pair.com smtp.mail=martin@divbyzero.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=martin@divbyzero.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain divbyzero.net from 87.230.111.147 cause and error) X-PHP-List-Original-Sender: martin@divbyzero.net X-Host-Fingerprint: 87.230.111.147 mx.bauer-kirch.de Linux 2.6 Received: from [87.230.111.147] ([87.230.111.147:54051] helo=mx.bauer-kirch.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C1/68-62408-C4649E05 for ; Sun, 06 Jan 2013 04:39:26 -0500 Received: by mx.bauer-kirch.de with ESMTP id 1TrmhN-00072h-H0; Sun, 06 Jan 2013 10:39:21 +0100 Message-ID: <50E94648.7000104@divbyzero.net> Date: Sun, 06 Jan 2013 10:39:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Stas Malyshev CC: PHP Internals References: <50E90DD1.7040204@sugarcrm.com> In-Reply-To: <50E90DD1.7040204@sugarcrm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Fixing insecure cURL file uploading From: martin@divbyzero.net (Martin Jansen) On 06.01.13 06:38, Stas Malyshev wrote: > https://wiki.php.net/rfc/curl-file-upload > > Please review and comment. If there's a general positive feedback, I'll > try to implement a patch for it pretty soon. Looks solid to me. One thing though: The manual spells the extension "cURL" and so does http://curl.haxx.se/. Shouldn't the new class then be called CURLFile instead of CurlFile? - Martin