Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64574
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.46 as permitted sender)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "Stas Malyshev" <smalyshev@sugarcrm.com>, =?utf-8?B?SsOhY2h5bSBUb3XFoWVr?=
 <enumag@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
References: <CACYoSNCr30Fg+oBASGmLYLk+ziXQy990mvZbLNUe8viNhZTdxQ@mail.gmail.com> <50E742A7.9010909@sugarcrm.com> <op.wqglnxjnqezz7x@jachym-pc> <50E8A99F.5000900@sugarcrm.com> <op.wqgotfcfqezz7x@jachym-pc>
Date: Sun, 06 Jan 2013 00:41:56 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: Quoted-Printable
Message-ID: <op.wqgpf6oeqezz7x@jachym-pc>
In-Reply-To: <op.wqgotfcfqezz7x@jachym-pc>
User-Agent: Opera Mail/12.11 (Win32)
Subject: Re: [PHP-DEV] How to get a PHP bug fixed?
From: enumag@gmail.com (=?utf-8?B?SsOhY2h5bSBUb3XFoWVr?=)

And by tests I mean fixing all the old tests which use Exception::getTra=
ce(). There is no need to write a new test(s).


Dne Sun, 06 Jan 2013 00:28:17 +0100 J=C3=A1chym Tou=C5=A1ek <enumag@gmai=
l.com> napsal(a):

> Are you sure there should be the $options parameter? It would not save=
 any memory because the trace needs to be pregenerated regardless. Back =
compatibilty clearly doesn't need to be that strict in this case because=
 for example in case of debug_backtrace function the 'object' fields whe=
re added in 5.1.1 (not in 5.1.0!) and were enabled by default (there was=
n't even a way to disable them - that came with 5.2.5).
>
> With that in mind there is no need for the $options parameter in my op=
inon. Which meens the only thing missing is the tests, right?
>
>
> Dne Sat, 05 Jan 2013 23:30:55 +0100 Stas Malyshev <smalyshev@sugarcrm.=
com> napsal(a):
>
>> Hi!
>>
>>> I've looked into it and I'm not sure whether an option for getTrace
>>> method is the best way to solve this. I mean the trace is created
>>> along with the exception so it would have to be generated with the
>>> object fields regardless and then filtered if the option is not set.=

>>> I think it would be better to add new PHP directive for this
>>> (disabled by default for back compatibility).
>>
>> No, I don't think it is a good idea. We have too many config directiv=
es
>> already, and behavior-modifying directives is really not a good idea,=

>> since it is a global state with all its problems.
>>
>>> Also what do you mean by DEBUG_BACKTRACE_*?
>>
>> Constants used for trace parameters.