Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64458
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain bofh.bg from 212.50.12.79 cause and error)
Message-ID: <20121228181514.utdov86o3ocksgck@mail.orbitel.bg>
Date: Fri, 28 Dec 2012 18:15:14 +0200
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
References: <20121210142818.9erzxulg08cwwck8@mail.orbitel.bg>
	<CAMUwpuSOW1=tht0j5VR3cS5_Meny4jorj-Dg5DaRR4F52YjAag@mail.gmail.com>
	<20121228042651.edrb8sz5cs4sgwwc@mail.orbitel.bg>
	<CAL+t6cF21RkJMk_ZRYjfu-Z37o7M=YfGRkR2LXu5YLQkog1Nsw@mail.gmail.com>
	<20121228045131.3g44jjlw8cc4sgk4@mail.orbitel.bg>
	<50DD46AB.70601@sugarcrm.com>
In-Reply-To: <50DD46AB.70601@sugarcrm.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=windows-1251;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
User-Agent: Internet Messaging Program (IMP) H3 (4.1.6)
Subject: Re: [PHP-DEV] Bug #23955: Cookie Max-Age attribute
From: narf@bofh.bg (Andrey Andreev)

It is briefly noted in the RFC (mine, not 6265) that negative values =20
and 0 have the same effect. It's practically irrelevant which one is =20
sent.

My original commit actually did checks for negative values and sent =20
zeros instead of them, but then somebody on github pointed out that =20
they are legal, so I removed that logic. If not anything else, it =20
saves a few lines of code.

- Andrey

Quoting Stas Malyshev <smalyshev@sugarcrm.com>:

> Hi!
>
>> "Max-Age" would simply be added to all Set-Cookie headers, after the
>> "Expires" attribute. I thought that was obvious, but I'll make sure to
>> add a few examples to make it clearer.
>
> I think it makes sense, only note is that it makes no sense to set
> Max-Age to any negative number, especially as RFC 6265 treats all
> negative values and 0 as the same:
>
> If delta-seconds is less than or equal to zero (0), let expiry-time be
> the earliest representable date and time.  Otherwise, let the
> expiry-time be the current date and time plus delta-seconds seconds.