Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64453
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20121228045131.3g44jjlw8cc4sgk4@mail.orbitel.bg>
References: <20121210142818.9erzxulg08cwwck8@mail.orbitel.bg>
	<CAMUwpuSOW1=tht0j5VR3cS5_Meny4jorj-Dg5DaRR4F52YjAag@mail.gmail.com>
	<20121228042651.edrb8sz5cs4sgwwc@mail.orbitel.bg>
	<CAL+t6cF21RkJMk_ZRYjfu-Z37o7M=YfGRkR2LXu5YLQkog1Nsw@mail.gmail.com>
	<20121228045131.3g44jjlw8cc4sgk4@mail.orbitel.bg>
Date: Thu, 27 Dec 2012 22:00:39 -0500
Message-ID: <CAL+t6cGg9PF0Z=MHA_7eMh_oXfkjNkFzCBEHEs_9M3+he+LYkg@mail.gmail.com>
To: Andrey Andreev <narf@bofh.bg>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d043bdf384f5f7704d1e0de1e
Subject: Re: [PHP-DEV] Bug #23955: Cookie Max-Age attribute
From: theanomaly.is@gmail.com (Sherif Ramadan)

--f46d043bdf384f5f7704d1e0de1e
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Dec 27, 2012 at 9:51 PM, Andrey Andreev <narf@bofh.bg> wrote:

> Quoting Sherif Ramadan <theanomaly.is@gmail.com>:
>
>  There's no mention in the RFC of how the functionality will work in PHP.
>> Is
>> it possible to add example code of how it is to be used based on this
>> implementation?
>>
>
> "Max-Age" would simply be added to all Set-Cookie headers, after the
> "Expires" attribute. I thought that was obvious, but I'll make sure to add
> a few examples to make it clearer.


Well, even if it were obvious the RFC should be a technical specification
of what's being introduced. Things should be stated and explained there as
clearly as possible. At least so much so that people shouldn't have to
guess about what is going to actually happen when they run certain code.

For example, how are session cookies affected? What determines the actual
delta? I would assume it's the determined by the Unix timestamp supplied to
setcookie? Should setting this attribute in the response headers be
included automatically for session cookies? I would think it would, but I'm
not certain since it's not mentioned.

Other than some brief examples of usage and perhaps including those small
details I think it's pretty clear and I like the idea :)

Thanks for taking the time on that.


>
>
>  What BC breaks it introduced (if any)? Can there be an
>> option to use both Max-Age and Expires cookie attributes with the
>> introduced changes? How does the user know which attribute is being set?
>> None of this information seems to be in the RFC.
>>
>
> This is all (briefly) described under the "Technical details and
> considerations" section - both attributes should be sent and no side
> effects and/or breaking changes are expected.
>
> As for how a user would know it - just like with the current cookies being
> sent (either via setcookie() or by ext/session), by looking at their
> Set-Cookie HTTP headers.
>
>

--f46d043bdf384f5f7704d1e0de1e--