Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64440
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50DB6663.7010000@purple.org.ua>
References: <8D.41.07178.7380BD05@pb1.pair.com>
	<50DB6663.7010000@purple.org.ua>
Date: Wed, 26 Dec 2012 23:08:17 +0100
Message-ID: <CAF+90c-D3m3kWfJCbowyEQJd4x66GuPMU3L1m8G1ikkfrhnpAQ@mail.gmail.com>
To: Eugene L Kovalenja <iam@purple.org.ua>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0401696de071b104d1c8aa93
Subject: Re: [PHP-DEV] RFC: Add a deprecated modifier for functions
From: nikita.ppv@gmail.com (Nikita Popov)

--f46d0401696de071b104d1c8aa93
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Dec 26, 2012 at 10:04 PM, Eugene L Kovalenja <iam@purple.org.ua>wrote:

> Hello, Khalil
>
> Could you explain the pros of your proposal in comparison with the next
> one:
>
>    <?php
>
>    function somethingWillBeRemovedInNextVe**rsion() {
>          trigger_error('This function is deprecated. '
>              . 'Please use "newFunction" instead. ',
>          E_USER_DEPRECATED);
>
>
>          // functionality below
>
>          return 'something';
>    }
>
>    function newFunction() {
>         // ...
>    }
>
>    somethingWillBeRemovedInNextVe**rsion();
>
>
> From my point of view, the modifier for this kind of things is the
> restriction for developers, who want to inform user about details like "why
> we are going to remove this functionality".
>

I agree with Eugene. It's much better to throw a E_USER_DEPRECATED error
with a meaningful custom error message. So -1 on this.

Nikita

--f46d0401696de071b104d1c8aa93--