Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64430
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nFhBgZaVb3qyS6C5J2L87s85ZVpKMMOAJQAiyNTJqb+Cg@mail.gmail.com>
References: <B4E39E8F-B971-4909-9F79-612788FD2E6B@wiedler.ch>
	<CAL+t6cG2SEiB_O6FiG6WC372uoasg=ZhaRAc3SMGw4n3WTtv=g@mail.gmail.com>
	<7EF0DC28-1C66-4767-BF78-96F94BC28620@wiedler.ch>
	<CAL+t6cGq9nwbtOvfbYs0pow07Y_ZU+QOWHpCK+_uo6XF0SYoTg@mail.gmail.com>
	<CAAyV7nFhBgZaVb3qyS6C5J2L87s85ZVpKMMOAJQAiyNTJqb+Cg@mail.gmail.com>
Date: Mon, 24 Dec 2012 14:08:02 -0500
Message-ID: <CAL+t6cEFwRgAp6g9kw9xn6CQOsByMRajoQiBVZWvYHi=UF_1fA@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: Igor Wiedler <igor@wiedler.ch>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b5d449893e43f04d19dea63
Subject: Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear
From: theanomaly.is@gmail.com (Sherif Ramadan)

--047d7b5d449893e43f04d19dea63
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Dec 24, 2012 at 7:13 AM, Anthony Ferrara <ircmaxell@gmail.com>wrote:

> Sherif,
>
>
> You're right. It does break BC, but this was a bug fix.
>> https://bugs.php.net/bug.php?id=61038
>>
>> The behavior is incorrect in that regard.
>>
>
> However in this case that *bug* does have fairly significant BC
> implications.
>
> In fact, how I read the specification is that the original binary format
> is NULL padded, not the resulting string. Therefore, you could make the
> argument that the new behavior is wrong.
>
> In any case, I'd suggest reverting the "bug fix" for "a", and then adding
> Z which keeps the raw bytes. So that way the "bug" would be fixed by the
> "Z" parameter, but "a" would still behave as it always has (allowing things
> like Archive_Tar to still work properly).
>
> Otherwise it's a BC break that has weird implications (having different
> format specifications for 5.4 and 5.5, or requiring odd things like running
> trim on the output...
>
> My $0.02...
>
> Anthony
>


Hmm, the intent behind the fix was to get the behavior more inline with
Perl's pack/unpack as in PHP they weren't behaving the same way. Apparently
this has had some implications in the pecl/pear installer that I was not
aware of. The BC break can be reverted of course, but the idea was to only
put this patch in 5.5 because of the BC concern. Now that I recall the
situation I'm not sure what the best play is here, but I'll review this
again and see if this is indeed inline with the spec or not.

--047d7b5d449893e43f04d19dea63--