Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64424 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29914 invoked from network); 24 Dec 2012 12:13:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Dec 2012 12:13:39 -0000 Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.44 as permitted sender) X-PHP-List-Original-Sender: ircmaxell@gmail.com X-Host-Fingerprint: 209.85.212.44 mail-vb0-f44.google.com Received: from [209.85.212.44] ([209.85.212.44:42278] helo=mail-vb0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id ED/79-32426-1F648D05 for ; Mon, 24 Dec 2012 07:13:38 -0500 Received: by mail-vb0-f44.google.com with SMTP id fc26so7355171vbb.17 for ; Mon, 24 Dec 2012 04:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=NBoqXiPwD2Gv4WRjKal24wfcgaaUcMj7ronmYTp2gI4=; b=RVhA49HsX/He84brWFMUai6BoKNpaxvyIIgeIYszllA0b7VLHYASqHcY1OIMUhMYSS iyDXPRP7XXs3LDve8TtidHYpGYtfXiZQa4gkBd70w+WqMfC1IaqsrkLo1i2E09tkJflb Gy8SgZnB78gX5nv5QmCP5/4CtkiKCbwCZg0fmQ7PGBjZsc2x+b0ubDRqEQpKA8hdZtaa jnaKg256mrknEXqVh1LKlvZYr/FZgtXCc2vR7uqN1ccw0sbdtpx9vVgJd00fBSsxk/gY jDDkqsBwVXuAi9e4uKZUwL7rKNUumNfO1g2EJA1vGVcdU/toSq5YUVg3oN2r3ELzCZv/ kuxA== MIME-Version: 1.0 Received: by 10.58.243.166 with SMTP id wz6mr33644649vec.28.1356351215535; Mon, 24 Dec 2012 04:13:35 -0800 (PST) Received: by 10.58.200.130 with HTTP; Mon, 24 Dec 2012 04:13:35 -0800 (PST) In-Reply-To: References: <7EF0DC28-1C66-4767-BF78-96F94BC28620@wiedler.ch> Date: Mon, 24 Dec 2012 07:13:35 -0500 Message-ID: To: Sherif Ramadan Cc: Igor Wiedler , PHP Internals Content-Type: multipart/alternative; boundary=047d7b86f4b264872e04d19820bb Subject: Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear From: ircmaxell@gmail.com (Anthony Ferrara) --047d7b86f4b264872e04d19820bb Content-Type: text/plain; charset=ISO-8859-1 Sherif, You're right. It does break BC, but this was a bug fix. > https://bugs.php.net/bug.php?id=61038 > > The behavior is incorrect in that regard. > However in this case that *bug* does have fairly significant BC implications. In fact, how I read the specification is that the original binary format is NULL padded, not the resulting string. Therefore, you could make the argument that the new behavior is wrong. In any case, I'd suggest reverting the "bug fix" for "a", and then adding Z which keeps the raw bytes. So that way the "bug" would be fixed by the "Z" parameter, but "a" would still behave as it always has (allowing things like Archive_Tar to still work properly). Otherwise it's a BC break that has weird implications (having different format specifications for 5.4 and 5.5, or requiring odd things like running trim on the output... My $0.02... Anthony --047d7b86f4b264872e04d19820bb--