Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64415
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.210.177 cause and error)
Message-ID: <50D5A7F3.9010103@lerdorf.com>
Date: Sat, 22 Dec 2012 07:30:43 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>
CC: PHP Internals <internals@lists.php.net>
References: <CA+9eiLvck3pye3HDTuxSZoYJqm=Ycc_=fXfpVsPjZb=xD7CfzA@mail.gmail.com> <4B729EED-78A8-4E59-B954-5A74C5585E05@stefan-marr.de> <CA+9eiLvB4fwjq7UFptK+URh7mQcg5EQ_O-==W5MkDUqUOTsV=w@mail.gmail.com>
In-Reply-To: <CA+9eiLvB4fwjq7UFptK+URh7mQcg5EQ_O-==W5MkDUqUOTsV=w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Complete traits redesign for 5.5
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 12/21/2012 09:28 AM, Dmitry Stogov wrote:
> Hi,
> 
> This is more or less final proposed patch for 5.4
> 
> http://pastebin.com/ceiWWD4N
> 
> It fixes implementation mistakes and makes the whole implementation much
> simpler.
> I hope I didn't introduce new bugs :)
> Of course I checked it with PHP test suite, but it would be great to
> test it with real life applications that use traits.
> The patch keeps binary compatibility, and changes only error messages
> and behavior in error situations.
> It must not affect any applications.
> 
> I like to commit the patch in 5.4 and above on next week.
> 
> I would simplify the trait implementation much more, but the conflict
> resolution rules allows to make so many tricks that all needs to be
> checked :(
> Anyway, I'll think about it a bit more.
> 
> Any feedback is welcome.

You keep spelling "abstract" as "abstarct" throughout the patch. But it
looks good to me. I always like it when a patch removes more lines than
it adds.

-Rasmus