Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64411
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.219.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4B729EED-78A8-4E59-B954-5A74C5585E05@stefan-marr.de>
References: <CA+9eiLvck3pye3HDTuxSZoYJqm=Ycc_=fXfpVsPjZb=xD7CfzA@mail.gmail.com>
	<4B729EED-78A8-4E59-B954-5A74C5585E05@stefan-marr.de>
Date: Fri, 21 Dec 2012 17:28:43 +0300
Message-ID: <CA+9eiLvB4fwjq7UFptK+URh7mQcg5EQ_O-==W5MkDUqUOTsV=w@mail.gmail.com>
To: Stefan Marr <php@stefan-marr.de>, PHP Internals <internals@lists.php.net>
Cc: Zeev Suraski <zeev@zend.com>, Andi Gutmans <andi@zend.com>, Rasmus Lerdorf <rasmus@lerdorf.com>, 
	Xinchen Hui <laruence@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	Yoram Bar Haim <yoram.b@zend.com>
Content-Type: multipart/alternative; boundary=e89a8fb1f5002ac93404d15daa87
Subject: Re: [PHP-DEV] Complete traits redesign for 5.5
From: dmitry@zend.com (Dmitry Stogov)

--e89a8fb1f5002ac93404d15daa87
Content-Type: text/plain; charset=UTF-8

Hi,

This is more or less final proposed patch for 5.4

http://pastebin.com/ceiWWD4N

It fixes implementation mistakes and makes the whole implementation much
simpler.
I hope I didn't introduce new bugs :)
Of course I checked it with PHP test suite, but it would be great to test
it with real life applications that use traits.
The patch keeps binary compatibility, and changes only error messages and
behavior in error situations.
It must not affect any applications.

I like to commit the patch in 5.4 and above on next week.

I would simplify the trait implementation much more, but the conflict
resolution rules allows to make so many tricks that all needs to be checked
:(
Anyway, I'll think about it a bit more.

Any feedback is welcome.

Thanks. Dmitry.



On Tue, Dec 18, 2012 at 3:46 PM, Stefan Marr <php@stefan-marr.de> wrote:

> Hi Dmitry:
>
> On 18 Dec 2012, at 12:37, Dmitry Stogov wrote:
>
> > I'm going to take a deep look into trait implementation and provide a
> > better solution for 5.5.
> > The current implementation is really wired and makes a lot of troubles
> for
> > maintenance and each new fix, makes new troubles :(
> Sorry, that's mostly me lacking understanding of the PHP internals.
> And there are many wired corner cases that have to be covered.
>
> > I'm going to work on it with top priority during last few days and then
> > send a patch.
>
> Thanks for looking into it.
> I'll be able to test things over christmas.
>
> Best regards
> Stefan
>
>
> --
> Stefan Marr
> Software Languages Lab
> Vrije Universiteit Brussel
> Pleinlaan 2 / B-1050 Brussels / Belgium
> http://soft.vub.ac.be/~smarr
> Phone: +32 2 629 2974
> Fax:   +32 2 629 3525
>
>

--e89a8fb1f5002ac93404d15daa87--