Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64404 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19664 invoked from network); 21 Dec 2012 08:53:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Dec 2012 08:53:27 -0000 Authentication-Results: pb1.pair.com header.from=php@bof.de; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=brianofish@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.48 as permitted sender) X-PHP-List-Original-Sender: brianofish@gmail.com X-Host-Fingerprint: 74.125.83.48 mail-ee0-f48.google.com Received: from [74.125.83.48] ([74.125.83.48:48740] helo=mail-ee0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/C4-20281-58324D05 for ; Fri, 21 Dec 2012 03:53:26 -0500 Received: by mail-ee0-f48.google.com with SMTP id b57so2277006eek.35 for ; Fri, 21 Dec 2012 00:53:23 -0800 (PST) X-Received: by 10.14.0.3 with SMTP id 3mr30186684eea.16.1356080003271; Fri, 21 Dec 2012 00:53:23 -0800 (PST) Received: from rofl.localnet ([213.135.15.139]) by mx.google.com with ESMTPS id f6sm20377789eeo.7.2012.12.21.00.53.21 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Dec 2012 00:53:22 -0800 (PST) To: internals@lists.php.net Cc: Stas Malyshev , Jani Ollikainen Date: Fri, 21 Dec 2012 09:53:18 +0100 Message-ID: <1945070.GzMC8JlVeD@rofl> User-Agent: KMail/4.9.4 (Linux/3.6.11-k10-bof; KDE/4.9.4; x86_64; ; ) In-Reply-To: <50D40E7F.8030804@sugarcrm.com> References: <50D1D9B9.4060505@mmd.net> <5952719.MaJMSR3yMW@rofl> <50D40E7F.8030804@sugarcrm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [PHP-DEV] Crashes in lex_scan at Zend/zend_language_scanner.c / BUG #52752 From: php@bof.de (Patrick Schaaf) On Thursday 20 December 2012 23:23:43 Stas Malyshev wrote: > Hi! > > > Is include supposed to take a LOCK_EX somehow? I can neither see that in > > php- src (5.4.9) nor APC-trunk, doing a cursory grepping. > > I'm not sure how any lock would help, since locks are optional, meaning > you still can do the same thing without the locks. I'm well aware of the advisory nature of file locks. include taking a LOCK_EX could have helped - when any .tpl file modifying code also does LOCK_EX. I do NOT want to propose include doing that! It's just that the original poster or whoever created that piece of code with LOCK_EX in the file_put_contents(), apparently thought it might work out that way. tmpfiles and rename are definitely the correct way to handle that. best regards Patrick