Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64401
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mmd.net from 80.83.1.197 cause and error)
Message-ID: <50D420D7.7030203@mmd.net>
Date: Fri, 21 Dec 2012 10:41:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <50D1D9B9.4060505@mmd.net> <50D30656.8090207@mmd.net> <50D35BA0.5010301@sugarcrm.com> <5952719.MaJMSR3yMW@rofl>
In-Reply-To: <5952719.MaJMSR3yMW@rofl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Crashes in lex_scan at  Zend/zend_language_scanner.c
 / BUG #52752
From: jani.ollikainen@mmd.net (Jani Ollikainen)

Hi,

On 21.12.2012 8:15, Patrick Schaaf wrote:
>   APC takes a LOCK_EX in exactly one place, apc_bin_dumpfile(), which does not
> look to me like it's related to "include". The usage there is fishy anyway,
> not exactly sure, but I think the open that happens before taking LOCK_EX,
> will have truncated the file already, leading to the same type of problem as
> discussed above wrt concurrent readers.

Usage is fishy, but it's small and can reproduce the error. Don't really 
know what code hits that in my production environment or
is it even the same problem but it seems to have similar backtrace.

> So, my conclusion would be that it is the code snippet above, and not any part
> of PHP or the kernel, that is at fault.

Oh? Did I understand you correctly? If you can code PHP that crashes 
PHP, it's that codes fault not PHP's fault? I've always thought PHP
to be high level programming language where PHP handles things for
you and you can't code anything that crashes it like that with
bus error?

I think that it should at least gracefully exit, log error, what caused 
what and where. Better option would be that it just works.

And if you don't see anything to be done in PHP, I think then at
least documentation of include/require should have big warning
explaining that PHP doesn't guarantee include/require not to
crash PHP itself.