Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64392
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.219.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50D34512.1040708@lerdorf.com>
References: <CA+9eiLvck3pye3HDTuxSZoYJqm=Ycc_=fXfpVsPjZb=xD7CfzA@mail.gmail.com>
	<CAPwsocH8O0tmzxSCdHYR-L7WEoQeHN+wJV2R9DOpovGs7HtWNA@mail.gmail.com>
	<CA+9eiLvWbVe3iS-sYEveqoSHxzg+CZKvfdKkmY5gWJASwoRLdQ@mail.gmail.com>
	<50D210F9.8050707@lerdorf.com>
	<CA+9eiLv0eN3buwQ0cHeqhR4ORL-bQG25H_rquNW_T0W8FWytZA@mail.gmail.com>
	<CAEZPtU74n2NYOOiNYXg3Hzn5YbFd=nNxZv=fQD6MZYDb+5z7Mw@mail.gmail.com>
	<CAEZPtU6BR6Qi-cBp4m6TVfbpdh_d2hF_S31-=R3-UVu0PsxULQ@mail.gmail.com>
	<CA+9eiLtnyH1O0PgYTMLsHMo8GtACUJJCJ4zmSbNFEQLnAwOD8A@mail.gmail.com>
	<50D34512.1040708@lerdorf.com>
Date: Fri, 21 Dec 2012 02:33:41 +0300
Message-ID: <CA+9eiLvDLbNUczFMCH-jqUssBtkvnk8RTFdz5bc0s7zYBxLJCA@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Pierre Joye <pierre.php@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec54a33903ff68104d15129eb
Subject: Re: [PHP-DEV] Complete traits redesign for 5.5
From: dmitry@zend.com (Dmitry Stogov)

--bcaec54a33903ff68104d15129eb
Content-Type: text/plain; charset=UTF-8

hi Rasmus,

I don't know all the APC internals, but it seems it just doesn't free
memory carefully.
It sets zend_class_entry->refcount to something above 1000 and as result
all the nested structures are not freed as expected by destroy_zend_class().

I'm not sure which side effects this may have, but one of them is avoiding
of the trait related problem :)

Of course, It produces many memory leaks but most of them (probably all)
must be handled by zend_alloc

$ PHP_FCGI_MAX_REQUESTS=2 USE_ZEND_ALLOC=0 valgrind sapi/cgi/php-cgi -b
/tmp/fcgi-php5
...
==30930==    definitely lost: 676 bytes in 10 blocks
==30930==    indirectly lost: 1,213 bytes in 24 blocks
...

~2K memory leaks on 2 HTTP requests (the same trait.php test)

It also must change the destruction order of static members and methods
static variables, but I'm too lazy to prove it.

Anyway, the traits problem really exists and I almost found a solution for
5.4 without BC break.
I'll post a patch tomorrow or on next week.

Thanks. Dmitry.

On Thu, Dec 20, 2012 at 9:04 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> On 12/20/2012 06:36 AM, Dmitry Stogov wrote:
> > Hi Pierre,
> >
> > The following test may crash on the second request with opcode cache.
> >
> > <?php
> >
> > trait THello {
> >
> >   public function hello() { echo 'Hello'; }
> > }
> >
> > class TraitsTest { use THello; }
> >
> > $test = new TraitsTest();
> > $test->hello();
> >
> > ?>
> >
> > Valgrind shows the problem even if PHP doesn't crash.
>
> I'm not seeing anything from Valgrind's memcheck on this under php -S
> with current PHP 5.4 and APC. Testing on 64-bit Linux.
>
> -Rasmus
>
>

--bcaec54a33903ff68104d15129eb--