Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64377
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.219.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU6BR6Qi-cBp4m6TVfbpdh_d2hF_S31-=R3-UVu0PsxULQ@mail.gmail.com>
References: <CA+9eiLvck3pye3HDTuxSZoYJqm=Ycc_=fXfpVsPjZb=xD7CfzA@mail.gmail.com>
	<CAPwsocH8O0tmzxSCdHYR-L7WEoQeHN+wJV2R9DOpovGs7HtWNA@mail.gmail.com>
	<CA+9eiLvWbVe3iS-sYEveqoSHxzg+CZKvfdKkmY5gWJASwoRLdQ@mail.gmail.com>
	<50D210F9.8050707@lerdorf.com>
	<CA+9eiLv0eN3buwQ0cHeqhR4ORL-bQG25H_rquNW_T0W8FWytZA@mail.gmail.com>
	<CAEZPtU74n2NYOOiNYXg3Hzn5YbFd=nNxZv=fQD6MZYDb+5z7Mw@mail.gmail.com>
	<CAEZPtU6BR6Qi-cBp4m6TVfbpdh_d2hF_S31-=R3-UVu0PsxULQ@mail.gmail.com>
Date: Thu, 20 Dec 2012 14:36:43 +0300
Message-ID: <CA+9eiLtnyH1O0PgYTMLsHMo8GtACUJJCJ4zmSbNFEQLnAwOD8A@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8fb1f5002c0da104d14725e9
Subject: Re: [PHP-DEV] Complete traits redesign for 5.5
From: dmitry@zend.com (Dmitry Stogov)

--e89a8fb1f5002c0da104d14725e9
Content-Type: text/plain; charset=UTF-8

Hi Pierre,

The following test may crash on the second request with opcode cache.

<?php

trait THello {

  public function hello() { echo 'Hello'; }
}

class TraitsTest { use THello; }

$test = new TraitsTest();
$test->hello();

?>

Valgrind shows the problem even if PHP doesn't crash.

==2623== Invalid free() / delete / delete[] / realloc()
==2623== at 0x4007F0F: free (vg_replace_malloc.c:446)
==2623== by 0x837CC7C: zend_clear_trait_method_name (zend_opcode.c:273)
==2623== by 0x8393B1B: zend_hash_apply (zend_hash.c:716)
==2623== by 0x837D4C7: destroy_zend_class (zend_opcode.c:312)
==2623== by 0x8392464: zend_hash_apply_deleter (zend_hash.c:650)
==2623== by 0x8393D38: zend_hash_reverse_apply (zend_hash.c:804)
==2623== by 0x8378C3B: shutdown_executor (zend_execute_API.c:305)
==2623== by 0x8386C09: zend_deactivate (zend.c:938)
==2623== by 0x8329815: php_request_shutdown (main.c:1790)
With opcode cache op_code->function_name is actually allocated in shared
memory .

Thanks. Dmitry.

On Thu, Dec 20, 2012 at 12:07 PM, Pierre Joye <pierre.php@gmail.com> wrote:

> btw, same to test your changes/branch, as we have seen some crashes
> happening more easily on windows (same bug(s) on linux but with harder
> to get them crash).
>
> On Thu, Dec 20, 2012 at 9:02 AM, Pierre Joye <pierre.php@gmail.com> wrote:
> > hi Dmitry!
> >
> > On Thu, Dec 20, 2012 at 7:54 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> >
> > Thanks a lot to work on that :)
> >
> >> I'm not sure about APC, I saw the problem in ZendOptimizerPlus with
> >> php-5.4.10.
> >> O+ crashes (or corrupts memory and crashes on following requests) on
> each
> >> trait usage.
> >> The problem that PHP tries to deallocate names of methods defined in
> >> traits, but O+ keeps them in SHM.
> >> I believe APC must have the same problem.
> >
> > Do you have some phpt to share? I can run them in our tests labs and
> > report issues to the bugs tracker, and see if Anatolyi can help to fix
> > them as well.
> >
> >
> > Cheers,
> > --
> > Pierre
> >
> > @pierrejoye
>
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>

--e89a8fb1f5002c0da104d14725e9--