Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64304
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 213.123.20.127 cause and error)
Message-ID: <50CE252D.5060305@lsces.co.uk>
Date: Sun, 16 Dec 2012 19:46:53 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120826 Firefox/15.0 SeaMonkey/2.12
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
References: <EAA1F7DF-374E-4AB4-9ACD-F2C0CC3AE821@strojny.net> <50CDDA20.8090400@lsces.co.uk> <CAEZPtU7T5sx3V29PY1koGU4L_=_RXSD21T5aoeFtu10oEtxwCw@mail.gmail.com>
In-Reply-To: <CAEZPtU7T5sx3V29PY1koGU4L_=_RXSD21T5aoeFtu10oEtxwCw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Core liason for PHP FIG
From: lester@lsces.co.uk (Lester Caine)

Pierre Joye wrote:
> On Sun, Dec 16, 2012 at 3:26 PM, Lester Caine<lester@lsces.co.uk>  wrote:
> <snip>
>> >
> Once again this is totally off base. We are not discussing anything
> proposed or adopted by the FIG group but how php.net can better
> cooperate with this group. I urge you to stay on topic and move any
> other topics to the right place.

Actually the question is perfectly valid ... why do we standardise on using TAB 
in the core code, but then use spaces in the php files?
It would seem that FIG group standards have been adopted in some areas of PHP 
when the real standard is something different?
I've just realised why I have been having problems with some area which USED to 
use the TAB standard but which have been switched to 'spaces' instead! So what 
IS the standard for file style in core code files? While ignoring white space on 
comparisons does work, it also results in problems when trying to commit changes 
to files which are using different white space standards.

OK - scanning a few more files it would seem that spaces are an exception 
(fetch.php for example), and I've found the guideline calling for tab rather 
than spaces, but does that guideline apply transparently to .php files as well? 
Certainly .phpt files are consistently tabbed.

It's not the only difference that FIG are pushing which is opposite to the style 
standards on the core code, so perhaps we should be lobbying them to come in 
line with the documented standards?

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk