Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64263
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
Content-Type: text/plain; charset=koi8-r; format=flowed; delsp=yes
To: "Marco Pivetta" <ocramius@gmail.com>, "Stas Malyshev"
 <smalyshev@sugarcrm.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
References: <op.wo3wsgnzc8onze@debian-nnefedov.local>
 <50C69191.5020201@sugarcrm.com> <op.wo490acvc9evq2@debian-nnefedov.local>
 <CADyq6s+BQk8R5KyDxLhhBT5DZhYSqcQg9cbhzNd4nohZztbmJA@mail.gmail.com>
 <50C767FD.8070901@sugarcrm.com>
Date: Tue, 11 Dec 2012 21:20:15 +0400
MIME-Version: 1.0
Content-Transfer-Encoding: Quoted-Printable
Organization: home
Message-ID: <op.wo5w330ezh3ah1@xn--adm--jpa3a>
In-Reply-To: <50C767FD.8070901@sugarcrm.com>
User-Agent: Opera Mail/12.11 (Win32)
Subject: Re: [PHP-DEV] DateTime improvement
From: inefedor@gmail.com (=?koi8-r?B?7snLydTB?=)

Stas Malyshev <smalyshev@sugarcrm.com> =D0=C9=D3=C1=CC(=C1) =D7 =D3=D7=CF=
=A3=CD =D0=C9=D3=D8=CD=C5 Tue, 11 Dec  =

2012 21:06:05 +0400:

> Hi!
>
>> As Nikita says, from an ORM perspective, an object is always immutabl=
e
>> (at least with current implementations I know of), and that's because=

>> they can simply use the object hashes to identify two different objec=
ts.
>
> Why for ORM Date is even an object? In most databases, date is a basic=

> value type, and should be accepted by value, not as a complex object.
> So, it should also be identified as the value - for number 1, you do n=
ot
> need additional identity or hash except it being number 1, same should=

> be for dates.

Then why do we even need DateTime class? We could stay with functions. I=
  =

think if we want to bring some OOP in php, then we need to do it right w=
ay.

>> I don't believe (at all) in "if you don't need it mutable, don't use
>> modify() oroverride modify()". If the API is there, people will use i=
t.
>> We tried to implement an immutable DateTime in userland, but it doesn=
't
>> work out well...
>
> Why it doesn't work well and why PHP needs to be changed because of it=
?

Because of some DateTime's limitations - you will end up making brand ne=
w  =

DateTime class, reimplementing *all* the features that were implemented =
in  =

DateTime. At first - you can't just extend DateTime, because of  =

factory-methods - so that way you will need to use decorator, but even  =

with this approach (pretty shitty approach I must say) there would be  =

problems with diff() method (if you want to use DateTime's diff, you wil=
l  =

need to implement getDateTime method of your own DateTime class (because=
  =

diff accepts DateTime), so you will end with mutable object again, becau=
se  =

one can just execute $yourDate->getDateTime()->modify(*whatever you  =

want*)).

I think it should be changed (or implemented another one, like someone  =

said, DateTimeImmutable) because date is atomic value.