Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64219
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <4ED7146272E04A47B986ED49E771E347BB362B68DE@Ikarus.ameusgmbh.intern>
Date: Mon, 10 Dec 2012 16:23:58 +0400
MIME-Version: 1.0
Content-Transfer-Encoding: Quoted-Printable
Message-ID: <op.wo3op8p6c9evq2@debian-nnefedov.local>
In-Reply-To: <4ED7146272E04A47B986ED49E771E347BB362B68DE@Ikarus.ameusgmbh.intern>
User-Agent: Opera Mail/12.11 (Linux)
Subject: Re: [PHP-DEV] Improve DateTime Class
From: inefedor@gmail.com ("Nikita Nefedov")

On Mon, 10 Dec 2012 16:09:36 +0400, Christian Stoller <stoller@leonex.de=
>  =

wrote:

> Hi internals,
>
> what do you think about improving the modification functionality of th=
e  =

> DateTime class. I always get a cold shiver, when I write something lik=
e  =

> this:
> <?php
> $date =3D new DateTime()
> $date->modify(=E2=80=98+15 day=E2=80=99);
>
> In my opinion it would be nicer if one could write:
> $date->modify(15, DateTime::INTERVAL_DAY); // for adding 15 days
> $date->modify(-15, DateTime::INTERVAL_DAY); // for subtracting 15 days=

>
> Even better would be to have methods like addDays(), addMonths(), etc.=

>
> This would make it cleaner and more readable. You do not have to do  =

> something like this:
>
> $date =3D new DateTime();
> $date->modify(getDaysToAddMethod() . " day"); // I am not sure if a '+=
'  =

> sign is needed if the value is positive
>
> And it is fully backward compatible.
>
> Best regards
> Christian
>

Hi,

I think we shouldn't improve this functionality because modifying date  =

object in the first place is bad idea. Think about it as monatomic objec=
t,  =

like integer, you can't create new integer object of 42 and then just  =

change its value - it will be another object.

As a workaround you could create your own date class, extend it from  =

\DateTime and add what you want.