Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64183 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 30714 invoked from network); 6 Dec 2012 15:25:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Dec 2012 15:25:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=njaguar@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=njaguar@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.42 as permitted sender) X-PHP-List-Original-Sender: njaguar@gmail.com X-Host-Fingerprint: 209.85.219.42 mail-oa0-f42.google.com Received: from [209.85.219.42] ([209.85.219.42:63698] helo=mail-oa0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 49/60-27691-AE8B0C05 for ; Thu, 06 Dec 2012 10:25:30 -0500 Received: by mail-oa0-f42.google.com with SMTP id j1so6893769oag.29 for ; Thu, 06 Dec 2012 07:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=DsDwYt7L+87GKt4ao2NwNgmdRP3SvGM1c1nwoZ85NdE=; b=YTaDyD2rhzjWcasVbHtfeifcR3M88aBOr3qoGtogpRkgxlJsZlTgQxhsVydWCZRd/l N/j/QzdcSCQqWIkaQpy9v+6whHiiaxMsPN6AMlIMB4hI604G14QEvPXLU1hTgZq9Tj/n kUUv9JmhDo+0GaTNcSddMwBeplkhSsOtCeEN4gRJJUTmvVPW6gN5MjAR8YsAJWxvgveE FqKDULGYp30uouJCH1MA/eyR9gzHjaYhao/OVV1xgE4XlgHD5nwOg3hyR/KGe3DtaKLT CFKmpxAAtD0X5UvJ7GKMUTuvCr3c3qzusc7P1XJUHd0XJPbWyKMKVB7C1tjUje92AXlb jpTQ== MIME-Version: 1.0 Received: by 10.60.3.1 with SMTP id 1mr1057204oey.138.1354807527765; Thu, 06 Dec 2012 07:25:27 -0800 (PST) Received: by 10.182.89.66 with HTTP; Thu, 6 Dec 2012 07:25:27 -0800 (PST) Date: Thu, 6 Dec 2012 09:25:27 -0600 Message-ID: To: internals@lists.php.net Content-Type: multipart/mixed; boundary=e89a8fb1ff166e783804d030b533 Subject: Re: Bug #63615 DateTime::modify() ignores timezone [PATCH] From: njaguar@gmail.com (Paul Taulborg) --e89a8fb1ff166e783804d030b533 Content-Type: text/plain; charset=ISO-8859-1 Okay, here is the proper fixed patch, tested via various methods: $d1 = new DateTime; while(1) { // no memory leak $d1->modify("Tue, 10 Apr 2012 11:27:56 +0300"); // memory leak - now fixed with new patch $d1->modify("Tue, 10 Apr 2012 11:27:56 CST"); // no memory leak $d1->modify("Tue, 10 Apr 2012 11:27:56 Pacific/Chatham"); } Attaching this second patch to the original bug report, as well as including here. Thanks! --e89a8fb1ff166e783804d030b533 Content-Type: text/plain; charset=US-ASCII; name="bug_63615_patch_2.txt" Content-Disposition: attachment; filename="bug_63615_patch_2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hae1e8jy0 LS0tIC4uL3BocC01LjQuOV9vcmlnL2V4dC9kYXRlL3BocF9kYXRlLmMJMjAxMi0xMS0yMCAyMzox MjoyMC4wMDAwMDAwMDAgLTA2MDAKKysrIGV4dC9kYXRlL3BocF9kYXRlLmMJMjAxMi0xMi0wNiAw MzoxOToyNi41OTczMDE5OTMgLTA2MDAKQEAgLTI3NjMsNiArMjc2MywyNSBAQAogCQkJZGF0ZW9i ai0+dGltZS0+cyA9IDA7CiAJCX0KIAl9CisKKwlpZih0bXBfdGltZS0+em9uZV90eXBlKSB7CisJ CWRhdGVvYmotPnRpbWUtPnpvbmVfdHlwZSA9IHRtcF90aW1lLT56b25lX3R5cGU7CisJCXN3aXRj aCAodG1wX3RpbWUtPnpvbmVfdHlwZSkgeworCQljYXNlIFRJTUVMSUJfWk9ORVRZUEVfSUQ6CisJ CQlkYXRlb2JqLT50aW1lLT50el9pbmZvID0gdG1wX3RpbWUtPnR6X2luZm87CisJCQlicmVhazsK KwkJY2FzZSBUSU1FTElCX1pPTkVUWVBFX09GRlNFVDoKKwkJCWRhdGVvYmotPnRpbWUtPnogPSB0 bXBfdGltZS0+ejsKKwkJCWJyZWFrOworCQljYXNlIFRJTUVMSUJfWk9ORVRZUEVfQUJCUjoKKwkJ CWlmKGRhdGVvYmotPnRpbWUtPnR6X2FiYnIpIGZyZWUoZGF0ZW9iai0+dGltZS0+dHpfYWJicik7 CisJCQlkYXRlb2JqLT50aW1lLT56ID0gdG1wX3RpbWUtPno7CisJCQlkYXRlb2JqLT50aW1lLT5k c3QgPSB0bXBfdGltZS0+ZHN0OworCQkJZGF0ZW9iai0+dGltZS0+dHpfYWJiciA9IHN0cmR1cCh0 bXBfdGltZS0+dHpfYWJicik7CisJCQlicmVhazsKKwkJfQorCX0KKwogCXRpbWVsaWJfdGltZV9k dG9yKHRtcF90aW1lKTsKIAogCXRpbWVsaWJfdXBkYXRlX3RzKGRhdGVvYmotPnRpbWUsIE5VTEwp Owo= --e89a8fb1ff166e783804d030b533--