Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64167 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50527 invoked from network); 5 Dec 2012 22:32:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Dec 2012 22:32:40 -0000 Authentication-Results: pb1.pair.com smtp.mail=njaguar@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=njaguar@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender) X-PHP-List-Original-Sender: njaguar@gmail.com X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:38445] helo=mail-ob0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C4/3A-04278-78BCFB05 for ; Wed, 05 Dec 2012 17:32:40 -0500 Received: by mail-ob0-f170.google.com with SMTP id wp18so5932639obc.29 for ; Wed, 05 Dec 2012 14:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=phV2Op9A5ob/W0IRNK6f3tWZRMmaBrHICB/xWgO+aEc=; b=woszDllKhK/lEDYNTrewZENE/M+UmxIMjiJHeTzjsz7Ofjj6j6U9wvdfNRqCo/j+Ti EBKO7VbD9R+i2T943VZUCQhpSNvxX1wkh3GyAeY+CxShg8Rd/hRdD5EoRMAI6DK77hSW JHMkiML+YtjMdNa4j2EVk0t1xUZMyP1spmYwOlrej6hUKAYfu+tUTskr0Jlaawflzpjz Tr+cJMg+Lapqb0IlQvrlqDX0yqz2dPTMDefa00EWBYPBuSojygQiEaishebKbJRD23uO B0NcUL503fPeNq8FmFzXKLKBHzSMZGIifbw+yi+DCOwqwZKLqxLb7aUKEjpLlFl/AFPg b7ew== MIME-Version: 1.0 Received: by 10.60.23.232 with SMTP id p8mr15013030oef.53.1354746756672; Wed, 05 Dec 2012 14:32:36 -0800 (PST) Received: by 10.182.89.66 with HTTP; Wed, 5 Dec 2012 14:32:36 -0800 (PST) Date: Wed, 5 Dec 2012 16:32:36 -0600 Message-ID: To: internals@lists.php.net Content-Type: multipart/mixed; boundary=e89a8ff1c6ca312c5104d0228f98 Subject: Bug #63615 DateTime::modify() ignores timezone [PATCH] From: njaguar@gmail.com (Paul Taulborg) --e89a8ff1c6ca312c5104d0228f98 Content-Type: text/plain; charset=ISO-8859-1 I looked into this, and the modify function was not setting the timezone information back to the parent dateobj. I have created a patch that does this, IF the timezone information is set on the new modified timestamp. It is attached to the bug itself, and here as well. This is, of course, assuming that date_modify() should actually modify the timezone information. If this is intended functionality, then this patch will fix it. If not, the bug should be closed as a no fix. Thanks --e89a8ff1c6ca312c5104d0228f98 Content-Type: text/plain; charset=US-ASCII; name="bug_63615_patch.txt" Content-Disposition: attachment; filename="bug_63615_patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_had17imn0 LS0tIC4uL3BocC01LjQuOV9vcmlnL2V4dC9kYXRlL3BocF9kYXRlLmMJMjAxMi0xMS0yMCAyMzox MjoyMC4wMDAwMDAwMDAgLTA2MDAKKysrIGV4dC9kYXRlL3BocF9kYXRlLmMJMjAxMi0xMi0wNSAx MDoyNzo0Ny41ODY0MjQ0ODEgLTA2MDAKQEAgLTI3NjMsNiArMjc2MywyNCBAQAogCQkJZGF0ZW9i ai0+dGltZS0+cyA9IDA7CiAJCX0KIAl9CisKKwlpZih0bXBfdGltZS0+em9uZV90eXBlKSB7CisJ CWRhdGVvYmotPnRpbWUtPnpvbmVfdHlwZSA9IHRtcF90aW1lLT56b25lX3R5cGU7CisJCXN3aXRj aCAodG1wX3RpbWUtPnpvbmVfdHlwZSkgeworCQljYXNlIFRJTUVMSUJfWk9ORVRZUEVfSUQ6CisJ CQlkYXRlb2JqLT50aW1lLT50el9pbmZvID0gdG1wX3RpbWUtPnR6X2luZm87CisJCQlicmVhazsK KwkJY2FzZSBUSU1FTElCX1pPTkVUWVBFX09GRlNFVDoKKwkJCWRhdGVvYmotPnRpbWUtPnogPSB0 bXBfdGltZS0+ejsKKwkJCWJyZWFrOworCQljYXNlIFRJTUVMSUJfWk9ORVRZUEVfQUJCUjoKKwkJ CWRhdGVvYmotPnRpbWUtPnogPSB0bXBfdGltZS0+ejsKKwkJCWRhdGVvYmotPnRpbWUtPmRzdCA9 IHRtcF90aW1lLT5kc3Q7CisJCQlkYXRlb2JqLT50aW1lLT50el9hYmJyID0gc3RyZHVwKHRtcF90 aW1lLT50el9hYmJyKTsKKwkJCWJyZWFrOworCQl9CisJfQorCiAJdGltZWxpYl90aW1lX2R0b3Io dG1wX3RpbWUpOwogCiAJdGltZWxpYl91cGRhdGVfdHMoZGF0ZW9iai0+dGltZSwgTlVMTCk7Cg== --e89a8ff1c6ca312c5104d0228f98--