Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64154 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82072 invoked from network); 5 Dec 2012 07:06:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Dec 2012 07:06:56 -0000 Authentication-Results: pb1.pair.com header.from=sebastian@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=sebastian@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 93.190.64.36 as permitted sender) X-PHP-List-Original-Sender: sebastian@php.net X-Host-Fingerprint: 93.190.64.36 mail-6.de-punkt.de Received: from [93.190.64.36] ([93.190.64.36:41063] helo=mail-6.de-punkt.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 38/31-04278-E82FEB05 for ; Wed, 05 Dec 2012 02:06:55 -0500 Received: (qmail 4755 invoked by uid 511); 5 Dec 2012 07:06:50 -0000 Received: by simscan 1.3.1 ppid: 4751, pid: 4753, t: 0.0320s scanners: attach: 1.4.0 Received: from unknown (HELO ?192.168.2.66?) (php%sebastian-bergmann.de@84.150.82.35) by 0 with ESMTPA; 5 Dec 2012 07:06:50 -0000 Message-ID: <50BEF28B.6000404@php.net> Date: Wed, 05 Dec 2012 08:06:51 +0100 Reply-To: internals@lists.php.net User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: internals@lists.php.net References: <50BDB27A.7030205@php.net> <50BED659.8090606@sugarcrm.com> In-Reply-To: <50BED659.8090606@sugarcrm.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] re2c --no-generation-date From: sebastian@php.net (Sebastian Bergmann) On 12/05/2012 06:06 AM, Stas Malyshev wrote: >> Any objections to applying the attached patch? This would suppress date >> output in the generated output so that (hopefully) files generated by >> re2c are not changed during the build just because of the date. > > I think it is a great idea. If we ever need a date for checked in files, > we have it on git commit, date in the text is not useful anyway. Okay. But does the patch look okay? Is it sufficient? How can I force a rebuild of all files generated through re2c to remove the date from the files? To which branches should the patch be applied? Thanks!