Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64138
Return-Path: <julienpauli@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 98097 invoked from network); 3 Dec 2012 14:27:34 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 3 Dec 2012 14:27:34 -0000
Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.170 as permitted sender)
X-PHP-List-Original-Sender: julienpauli@gmail.com
X-Host-Fingerprint: 209.85.223.170 mail-ie0-f170.google.com  
Received: from [209.85.223.170] ([209.85.223.170:64029] helo=mail-ie0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 49/43-03565-5D6BCB05 for <internals@lists.php.net>; Mon, 03 Dec 2012 09:27:34 -0500
Received: by mail-ie0-f170.google.com with SMTP id k10so4633486iea.29
        for <internals@lists.php.net>; Mon, 03 Dec 2012 06:27:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date
         :x-google-sender-auth:message-id:subject:to:cc:content-type;
        bh=Mi58Qhm4tPGgxlqSokesYJvuIHqC0AHLALPp9LlMhqA=;
        b=cfdUdDhqkeDjj5IyUXhxy/bL3aRWBNn6jaW/CsNocI/+5jV4ZspbiLtHaNpZSTDf0z
         /G1owB4gsj5qKCN5tWmj4ovqUyJLiB3nRkqkLIF2wfstuGIdYcGev2i4ue/pM6GuviP6
         f5V+6ic7DN45x4r+WI/WHO81CcPQ2sIk0T00MvC70jN4271koCO85aVSMk3IgKHgs60k
         +3FM9qb5zlp7rxjU3HmKVelcNiDaFbBYcYi1gEqmeM6evSAkk7eeOfpBiziIZMYLyuoZ
         5MMA2dwAp10D0kSeKlrZzu2Xw4gx5nZnKNCPMNo3xCElrOd37wseGFzuOnUNeZ7ACIfw
         utEQ==
Received: by 10.43.50.197 with SMTP id vf5mr7922601icb.13.1354544851355; Mon,
 03 Dec 2012 06:27:31 -0800 (PST)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
Received: by 10.64.140.106 with HTTP; Mon, 3 Dec 2012 06:26:48 -0800 (PST)
In-Reply-To: <CA+9eiLtnudJzS8AVEprDWaVYJZYJfQy1+1=orFjf9Qwn8Mu8kg@mail.gmail.com>
References: <CA+9eiLsojD5fPCbrYqqcLyYQ30jSU0yqAaPy=U_rzEG+Zd0vQQ@mail.gmail.com>
 <CA+9eiLu6neE9Wf3qo+rDFm5cKew-WMT65Drxz9YcKPrf14dOSw@mail.gmail.com>
 <CA+9eiLtgz+S=-aTWJXeUA+B4VZjpVEu=hWiJSpYZnRAsAeRPdA@mail.gmail.com>
 <201212031518.32545.yoram.b@zend.com> <CA+9eiLtnudJzS8AVEprDWaVYJZYJfQy1+1=orFjf9Qwn8Mu8kg@mail.gmail.com>
Date: Mon, 3 Dec 2012 15:26:48 +0100
X-Google-Sender-Auth: eBL6rtPuYVbyNCWuWjzw_s3923Y
Message-ID: <CAMUwpuRUBcSKXOLtJq-A-=rpS_e3rs7EaAFsp3VnThDS0aqGFQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: yoram bar haim <yoram.b@zend.com>, Rasmus Lerdorf <rasmus@lerdorf.com>, Derick <derick@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec52999cdb28b3e04cff38c1f
Subject: Re: [PHP-DEV] execute_data->Ts removing
From: jpauli@php.net (jpauli)

--bcaec52999cdb28b3e04cff38c1f
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Dec 3, 2012 at 2:26 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Yoram,
>
> Yeas, I checked memory reads on a release PHP built (with -O2 optimization
> level).
>
> The idea is very simple. Before the patch each access to TMP was
> implemented as:
>
> execute_data->Ts + offset
>
> GCC with -O2 kept execute_data in register but it needed to read
> execute_data->Ts anyway and then add the offset
>
> Now we just add the offset to execute_data directly.
>
> Also, the patch I published today is not compatible with 64-bit systems.
> I already fixed it, and the fix is minimal.
>
> Thanks. Dmitry.
>

Great work Dmitry, as usual !

Julien

--bcaec52999cdb28b3e04cff38c1f--