Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64124
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.210.173 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <CAJRMtAHj5uU1cK2y1ULuZ_QAUx8nyiFz-1QhscMcGE9J9vJq8A@mail.gmail.com>
References: <CAJRMtAHPFUc4mRH_+zi3cM+UvAR8n-PCZJoJYUz6+5SZPQAS_Q@mail.gmail.com>
	<50B41783.90104@lerdorf.com>
	<CAESVnVpCLL966-hOp-U05Gea5djrqH_JJZ-jW53AUAtEedgkZw@mail.gmail.com>
	<50B44AFE.5030307@lerdorf.com>
	<CAESVnVrjCQ1Yms+mvCr5BCB9D4H8meW14WSN2bq3SH+0Ub6yZg@mail.gmail.com>
	<CAJRMtAHj5uU1cK2y1ULuZ_QAUx8nyiFz-1QhscMcGE9J9vJq8A@mail.gmail.com>
Date: Fri, 30 Nov 2012 14:22:49 -0800
Message-ID: <CAESVnVqeSN88U5hSOFk0KrbZF1S6tsUy4zV4S7XQp1JotKLgyQ@mail.gmail.com>
To: Raymond Irving <xwisdom@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] HHVM and PHP
From: pollita@php.net (Sara Golemon)

If you're so inclined to pursue it, you don't (technically) need to
modify PHP core at all.

1) Make an extension which hooks zend_compile_file (just as APC and
many others do).
2) First request of a file passes through to the real compiler and
both returns main() opcodes *and* sends a copy of main() (and any new
classes/functions) to JITter.
3) Subsequent requests get ZEND_INTERNAL_(FUNCTION|CLASS) stubs
created for calling JIT code
4) RSHUTDOWN method explicitly cleans up ZEND_USER_(FUNCTION|CLASSe)s
and JIT-stub ZEND_INTERNAL_(FUNCTION|CLASSe)s since the default sweep
will get confused by the staggered function/class types.

Only hard part in there is the JIT itself, but that was never going to
be simple. :)

On Fri, Nov 30, 2012 at 7:04 AM, Raymond Irving <xwisdom@gmail.com> wrote:
> Many thanks for the feedback.
>
> I would love see some JIT features added to the core as this would help to
> improve the overall performance.
>
> Sara,
>
> I like your extension idea as this would not require any changes to the
> core.
>
> Here's another idea:
> -----------------------------------
> 1. Modify PHP core to cache opcodes on first request
> 2. Create external program (or library) that can be scheduled to compile
> cached opcodes to native code when necessary. This can be scheduled as a
> cron job
> 3. PHP will then run either the cached opcodes or the compiles codes when
> the page is request a second time.
>
> In this solution you get bets of both worlds. PHP can execute opcode cache
> or  native code if it's available. There would be no need for the core to
> further compile or optimize the opcodes as the external program will perform
> these operations. The end result is that the application performance will
> improve with usage and time.
>
> What do you think?
>
> __
> Raymond
>
>
> On Tue, Nov 27, 2012 at 2:37 AM, Sara Golemon <pollita@php.net> wrote:
>>
>> On Mon, Nov 26, 2012 at 9:09 PM, Rasmus Lerdorf <rasmus@lerdorf.com>
>> wrote:
>> > On 11/26/2012 09:03 PM, Sara Golemon wrote:
>> >> P.S. - I do disagree with Rasmus' statement about none of us looking
>> >> at fitting a JIT into PHP. ;)
>> >
>> > I think you misread my reply. I specifically said that a JIT is a
>> > possibility, just not the HH approach.
>> >
>> No no, I caught that.  I was just being pedantic in that I *am*
>> looking at fitting a few JIT approaches into PHP (via extensions),
>> including one based on HipHop's approach. :p  But if we're still being
>> pedantic, then I should admit to not working too hard on that front.
>>
>> -Sara
>
>