Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64123 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20649 invoked from network); 30 Nov 2012 19:48:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Nov 2012 19:48:58 -0000 Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.212.54 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.212.54 mail-vb0-f54.google.com Received: from [209.85.212.54] ([209.85.212.54:59400] helo=mail-vb0-f54.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 32/F2-23831-8AD09B05 for ; Fri, 30 Nov 2012 14:48:57 -0500 Received: by mail-vb0-f54.google.com with SMTP id l1so10329639vba.13 for ; Fri, 30 Nov 2012 11:48:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding:x-gm-message-state; bh=G5+Ys3VoX3jnWMqh8nfvHYlms2HMyAwD3ClvVZHcUe0=; b=OkAjGEz8YD8Ukb0IaCqnP7imlb2z1duQF33q0ZiLoHVLc5clUJrc76pDuDrcnDOI4v SmPgey78hIID2G+SNuiDFjgy//Tz89qkIdG8vvoBjGrsr2ZPOh4ViWAfqtcmRwA+hQ72 WHuPph0fNfWQ31V7RhtFBDLNeqmahujdjVqOiqcHA18E+J+p52CVdBRGdVJJ+hJCFJ9Y gWrLr3/KCGD7G9irotB9E4ArK6oQe8Zur5RQBjdbnZJ5AFqy5w1Fq5ego0e0CiiVA0wk HmvsZ+OU3gQKnTnoJ1WjN7C1vW70fBQJPXv11dUwTRnPy18j6a/Wq6tuYtWFV1n8U3UB p9VA== Received: by 10.52.74.135 with SMTP id t7mr1690003vdv.18.1354304934228; Fri, 30 Nov 2012 11:48:54 -0800 (PST) Received: from [10.252.8.139] ([64.124.192.210]) by mx.google.com with ESMTPS id bj15sm2073782vdc.7.2012.11.30.11.48.52 (version=SSLv3 cipher=OTHER); Fri, 30 Nov 2012 11:48:53 -0800 (PST) Message-ID: <50B90DA4.606@lerdorf.com> Date: Fri, 30 Nov 2012 14:48:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Dmitry Stogov CC: Derick , jpauli@php.net, Yoram Bar Haim , PHP Internals References: In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQkzfdzZYO+he1tDCAwgkyIpiUkQmXdk0a6M8yyaRYheTjD94/j+uGzDI3ohZlOLtOa0gYqx Subject: Re: [PHP-DEV] execute_data->Ts removing From: rasmus@lerdorf.com (Rasmus Lerdorf) On 11/30/2012 09:15 AM, Dmitry Stogov wrote: > Hi, > > The NEWS and UPGRADING explains the details. > > http://pastebin.com/VC71Y8LV > > The patch is big, but actually quite simple. > I'm going to commit it on Monday or Tuesday (if no objections). > > I'm going to look into the similar optimization for CVs, but it's going to > be a bit more difficult. Looks good to me. I'll commit this change to APC when you commit it: Index: apc_zend.c =================================================================== --- apc_zend.c (revision 328577) +++ apc_zend.c (working copy) @@ -48,7 +48,11 @@ static opcode_handler_t *apc_original_opcode_handlers; static opcode_handler_t apc_opcode_handlers[APC_OPCODE_HANDLER_COUNT]; +#if PHP_MAJOR_VERSION >= 6 || PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION >= 5 +#define APC_EX_T(offset) (*EX_TMP_VAR(execute_data, offset)) +#else #define APC_EX_T(offset) (*(temp_variable *)((char*)execute_data->Ts + offset)) +#endif And there are a couple of extensions that are going to need similar changes because of this. pecl/optimizer, pecl/inclued, pecl/xhprof, pecl/operator and xdebug from a quick check. -Rasmus