Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64101
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAOhuFvaDNvTGLDA+DkM_XZjuLdXPdPi1fw0peyRBExePbwOuBg@mail.gmail.com>
References: <CAOhuFvaDNvTGLDA+DkM_XZjuLdXPdPi1fw0peyRBExePbwOuBg@mail.gmail.com>
Date: Thu, 29 Nov 2012 13:28:14 +0000
Message-ID: <CAKxcST-kZoQLyUGSoRRSHdHnTS2FL_=fAT_CF8EnMq9XFQ3j8w@mail.gmail.com>
To: Rafael Dohms <listas@rafaeldohms.com.br>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae9340a0953586e04cfa24101
Subject: Re: [PHP-DEV] SplDoublyLinkedList missing insertBefore/After
From: dragoonis@gmail.com (Paul Dragoonis)

--14dae9340a0953586e04cfa24101
Content-Type: text/plain; charset=ISO-8859-1

Hi Rafael,

I have worked on this code before and if the idea is accepted I'm happy to
add features to this class.

Let me know.
Thanks,
Paul.


On Thu, Nov 29, 2012 at 11:38 AM, Rafael Dohms <listas@rafaeldohms.com.br>wrote:

> I have just noticed that the current SPL inplementation of a
> DoublyLinkedList does not include methods to insert nodes into the middle
> of the list (insertBefore, insertAfter).
>
> After mentioning it I ran into a few people and other outbursts on the
> internet of more people who saw this and complained about it.
>
> I found a bug from 2009 (https://bugs.php.net/bug.php?id=48358) which
> mentions the case and has no Core response at all.
>
> I ask two questions:
>
> 1) Why was this bug never replied to, is there some reason these methods
> should not be implemented?
>
> 2) Is anyone willing to put up a patch for this? I imagine that if you are
> familiar with C and PHP source this is a quick implementation as its
> standard logic documented everywhere.
>
> I'm not familiar enough with the PHP source to do this myself, hence I'm
> asking for anyone willing to "champion" the patch.
>
> Thanks!
>
> --
> Rafael Dohms
> PHP Evangelist and Community Leader
> http://www.rafaeldohms.com.br
> http://www.amsterdamphp.nl
>

--14dae9340a0953586e04cfa24101--