Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64023
Return-Path: <johannes@schlueters.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 40692 invoked from network); 21 Nov 2012 08:58:15 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Nov 2012 08:58:15 -0000
Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
X-PHP-List-Original-Sender: johannes@schlueters.de
X-Host-Fingerprint: 217.114.211.66 config.schlueters.de  
Received: from [217.114.211.66] ([217.114.211.66:55261] helo=config.schlueters.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 36/39-20662-5A79CA05 for <internals@lists.php.net>; Wed, 21 Nov 2012 03:58:13 -0500
Received: from [192.168.2.20] (ppp-188-174-42-31.dynamic.mnet-online.de [188.174.42.31])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(Client did not present a certificate)
	by config.schlueters.de (Postfix) with ESMTPSA id E0EB2654FF;
	Wed, 21 Nov 2012 09:58:09 +0100 (CET)
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Adam Harvey <aharvey@php.net>, Philip Olson <philip@roshambo.org>, PHP
 Developers Mailing List <internals@lists.php.net>
In-Reply-To: <50AC94B8.4010104@sugarcrm.com>
References: <23CB37F5-E956-4A5C-8ECC-7CF347A9086C@roshambo.org>
	 <CAL+t6cF=2=vzfe2orVWo4NZ8N0akFfBOSKRdQg7nWBmTjphzsA@mail.gmail.com>
	 <CAH-PCH5GOOt8LG70Anja3WDfWd5CHeJxZyScZD0WWMB2CEBZfg@mail.gmail.com>
	 <CAL+t6cF+YEGb40dkV+FQZmDrLkT5PEMyQT2MEC=3uW83onbFBw@mail.gmail.com>
	 <CAF+90c_ATMm_cJu_Ed4Rfn9_McVA=MtKun-LG+MZbqq8c_arUg@mail.gmail.com>
	 <CAL+t6cFDZQEdOTr5G-1GZ6NAM-U6gphzt+42y6MhhmMKLxP8pg@mail.gmail.com>
	 <CAF+90c8o9Vpqk4jz7kTPYycio_p-v+ck8v_Sr786G7Ud0xuL7A@mail.gmail.com>
	 <F2DF6FC7-E254-4B0F-9136-5AAF050E9B9C@roshambo.org>
	 <50AC6A7A.6030504@sugarcrm.com>
	 <CADajX4Dhk8at4S-K0Yb3Bfmb100a0n11VfVneyt5DZMC7xviyA@mail.gmail.com>
	 <50AC75EE.60100@sugarcrm.com>
	 <CADajX4BntUfYZGVF+QE4GqPxP1EoAiH-t3tbgNv6c94_U5Z3HQ@mail.gmail.com>
	 <50AC94B8.4010104@sugarcrm.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 21 Nov 2012 09:58:35 +0100
Message-ID: <1353488315.3341.12.camel@guyrush>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Where did the _logo_ functions go?
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Wed, 2012-11-21 at 00:45 -0800, Stas Malyshev wrote:
> Hi!
> 
> > Actually, I'm going to retract my statement, and here's why:
> > http://svn.wp-plugins.org/praized-community/trunk/includes/php/praized-php/PraizedCipher.php
> 
> I think breaking this code is an advantage :) That's definitely not how
> php_logo_guid should be used and using it as a secure salt makes no
> sense at all. To add insult to injury, it's wrapped in an if()! Please
> make me unsee it.

Agree. We never guaranteed this to be any stable value.
And even using it to display the logo is error-prone: Whether the logo
can be shown depends on expose_php in php.ini.

johannes