Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:64020 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36021 invoked from network); 21 Nov 2012 08:45:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Nov 2012 08:45:49 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 173.203.6.139 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 173.203.6.139 smtp139.ord.emailsrvr.com Linux 2.6 Received: from [173.203.6.139] ([173.203.6.139:46604] helo=smtp139.ord.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4F/28-20662-CB49CA05 for ; Wed, 21 Nov 2012 03:45:48 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp26.relay.ord1a.emailsrvr.com (SMTP Server) with ESMTP id DF73B1C00CA; Wed, 21 Nov 2012 03:45:45 -0500 (EST) X-Virus-Scanned: OK Received: by smtp26.relay.ord1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 77EB01C00C3; Wed, 21 Nov 2012 03:45:45 -0500 (EST) Message-ID: <50AC94B8.4010104@sugarcrm.com> Date: Wed, 21 Nov 2012 00:45:44 -0800 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Adam Harvey CC: Philip Olson , PHP Developers Mailing List References: <23CB37F5-E956-4A5C-8ECC-7CF347A9086C@roshambo.org> <50AC6A7A.6030504@sugarcrm.com> <50AC75EE.60100@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Where did the _logo_ functions go? From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Actually, I'm going to retract my statement, and here's why: > http://svn.wp-plugins.org/praized-community/trunk/includes/php/praized-php/PraizedCipher.php I think breaking this code is an advantage :) That's definitely not how php_logo_guid should be used and using it as a secure salt makes no sense at all. To add insult to injury, it's wrapped in an if()! Please make me unsee it. > The rules are there to protect developers from having functions > dropped out from under them without warning. I know why the rules are. I just think in this case the function is clearly abused and delaying this improvement for at least a year because of somebody using logo guids as encryption salts makes no sense to me. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227