Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64017
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.219.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpdLmw_MVv1KzREEsus+yV79sg3+Ea56BCjq6bK4H5hVtA@mail.gmail.com>
References: <CABBJUpddoQWvv_tXPBbFZNtcBF+fRFCDVh_WKHpnuuEx9BbEAw@mail.gmail.com>
	<CA+9eiLu748DWv3C-RYhDVFTwNq1QJBqPBuv+ywxM-42QmuPC2A@mail.gmail.com>
	<CABBJUpdLmw_MVv1KzREEsus+yV79sg3+Ea56BCjq6bK4H5hVtA@mail.gmail.com>
Date: Wed, 21 Nov 2012 11:14:32 +0300
Message-ID: <CA+9eiLuPsobv4mWbwwj08ryrZHX9=81xH=Us892mGq_qxfJptg@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>, PECL Announce <pecl-dev@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04478999bf0c7a04cefcf0a4
Subject: Re: Expose zend_message_dispatcher_p
From: dmitry@zend.com (Dmitry Stogov)

--f46d04478999bf0c7a04cefcf0a4
Content-Type: text/plain; charset=ISO-8859-1

Great! I always glad to help. And I would avoid "tricky" solutions as much
as possible. :)

Even 2 minutes TTL is going to save few thousands syscalls, in case your
site is really
high loaded, and it make no sense to care about "last syscall optimization"
if you system is mostly idle.

BTW: I'm not sure if APC calls stat() for inclode_once(), but it definitely
possible not to call it.

Thanks. Dmitry,

On Wed, Nov 21, 2012 at 11:56 AM, Laruence <laruence@php.net> wrote:

> On Wed, Nov 21, 2012 at 2:35 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> > [see below]
> >
> > On Wed, Nov 21, 2012 at 6:39 AM, Laruence <laruence@php.net> wrote:
> >>
> >> Hey:
> >>
> >>    This problem come out when I was figuring a performance issue of
> >> Yaf_Loader.
> >>
> >>    Yaf provides a autoloader like PSR0,  when doing a classes
> >> autoloading. it used to:
> >>
> >>    1. stat the file,  if file does not exists,  return
> >>    2. zend_compile_file
> >>
> >>    this is okey when you  run yaf without opcode cache.
> >>
> >>    but when you run yaf with opcode cache,  the first stat syscall
> >> become a little waste.
> >
> >
> > You should just use  virtual_realpath() or tsrm_realpath() instead of
> > stat(). They must utilise realpath cache and avoid stat() calls.
> Hey:
>
>   Thanks, Dmitry,
>
>   actually,  I didn't do like that is because by default, realpath
> cache has 2min ttl.
>
>   but, after a second think,  I think this will be better than my
> current tricky implementation.. I will try in this way :)
>
> thanks
> >
> > Thanks. Dmitry.
> >
> >>
> >>    since opcode cache always hook the zend_compile_file, and compile
> >> the file from cache.
> >>
> >>    so,  I changed the autoload to:
> >>
> >>     1. zend_compile_file
> >>     2. if compile failed, then return.
> >>
> >>    but,  zend_compile_file will throw warning if the file doesn't
> >> exists via zend_message_dispatcher_p
> >>
> >>    so if zend_message_dispatcher_p is ZEND_API, then I can avoid using
> >> such mess codes:
> >> https://github.com/laruence/php-yaf/blob/master/yaf_loader.c#L377
> >>
> >>    what do you think?
> >>
> >>
> >> thanks
> >> --
> >> Laruence  Xinchen Hui
> >> http://www.laruence.com/
> >
> >
>
>
>
> --
> Laruence  Xinchen Hui
> http://www.laruence.com/
>

--f46d04478999bf0c7a04cefcf0a4--