Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64014
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
Sender: adam@adamharvey.name
In-Reply-To: <50AC75EE.60100@sugarcrm.com>
References: <23CB37F5-E956-4A5C-8ECC-7CF347A9086C@roshambo.org>
 <CAL+t6cF=2=vzfe2orVWo4NZ8N0akFfBOSKRdQg7nWBmTjphzsA@mail.gmail.com>
 <CAH-PCH5GOOt8LG70Anja3WDfWd5CHeJxZyScZD0WWMB2CEBZfg@mail.gmail.com>
 <CAL+t6cF+YEGb40dkV+FQZmDrLkT5PEMyQT2MEC=3uW83onbFBw@mail.gmail.com>
 <CAF+90c_ATMm_cJu_Ed4Rfn9_McVA=MtKun-LG+MZbqq8c_arUg@mail.gmail.com>
 <CAL+t6cFDZQEdOTr5G-1GZ6NAM-U6gphzt+42y6MhhmMKLxP8pg@mail.gmail.com>
 <CAF+90c8o9Vpqk4jz7kTPYycio_p-v+ck8v_Sr786G7Ud0xuL7A@mail.gmail.com>
 <F2DF6FC7-E254-4B0F-9136-5AAF050E9B9C@roshambo.org> <50AC6A7A.6030504@sugarcrm.com>
 <CADajX4Dhk8at4S-K0Yb3Bfmb100a0n11VfVneyt5DZMC7xviyA@mail.gmail.com> <50AC75EE.60100@sugarcrm.com>
Date: Wed, 21 Nov 2012 15:15:46 +0800
Message-ID: <CADajX4BntUfYZGVF+QE4GqPxP1EoAiH-t3tbgNv6c94_U5Z3HQ@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Philip Olson <philip@roshambo.org>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Where did the _logo_ functions go?
From: aharvey@php.net (Adam Harvey)

On 21 November 2012 14:34, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
>> it doesn't suit us to. I agree: in practice, I can't imagine anyone
>> caring a jot about these functions being removed, but we've said that
>> when we're going to remove something, we'll deprecate for a minor
>> release, then remove. Why don't we live up to it?
>
> Exactly because in practice it is not important.

Actually, I'm going to retract my statement, and here's why:
http://svn.wp-plugins.org/praized-community/trunk/includes/php/praized-php/PraizedCipher.php

Let's set aside that this is terribly misguided code[0]. If that was a
good enough reason to remove functionality willy-nilly, I could have
saved myself a lot of e-mails on the ext/mysql front. But (to my
horror) users are actually using php_logo_guid() in the wild. I
haven't searched for the other functions, but I assume there are cases
where they're used too.

And it's not just one WordPress plugin. Nanoweb[1] calls
php_logo_guid() on its demo page[2]. ErfurtWiki[3] has a similar demo
page[4]. There are other projects of dubious provenance on Ohloh that
call it too.

It may only be a handful of projects, none of which any of us have
probably ever heard of, or will ever hear a complaint from, but I bet
those projects are important to their creators.

> Rules are important, but it is also important to not lose the sight of
> the goal - why these rules exist and when they make sense.

The rules are there to protect developers from having functions
dropped out from under them without warning.

I don't see the problem with reverting this on the 5.5 branch only,
adding E_DEPRECATED warnings to the appropriate places, and making the
first item in the master UPGRADING guide for 5.6 be that these
functions were removed.

Adam

[0] Hell, it won't even "decrypt" or "encrypt" properly on April 1,
which is entertaining.
[1] "The PHP Web Server": http://nanoweb.si.kz/
[2] http://nanoweb-instant.googlecode.com/svn/trunk/www/vhosts/www.cgidemo.com/index.php
[3] http://sourceforge.net/projects/erfurtwiki/
[4] https://erfurtwiki.svn.sourceforge.net/svnroot/erfurtwiki/trunk/ewiki/examples/zendwiki.php