Newsgroups: php.internals,php.pecl.dev
Path: news.php.net
Xref: news.php.net php.internals:64012 php.pecl.dev:10001
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpddoQWvv_tXPBbFZNtcBF+fRFCDVh_WKHpnuuEx9BbEAw@mail.gmail.com>
References: <CABBJUpddoQWvv_tXPBbFZNtcBF+fRFCDVh_WKHpnuuEx9BbEAw@mail.gmail.com>
Date: Wed, 21 Nov 2012 09:35:09 +0300
Message-ID: <CA+9eiLu748DWv3C-RYhDVFTwNq1QJBqPBuv+ywxM-42QmuPC2A@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>, PECL Announce <pecl-dev@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8fb1f8045470a204cefb8d78
Subject: Re: Expose zend_message_dispatcher_p
From: dmitry@zend.com (Dmitry Stogov)

--e89a8fb1f8045470a204cefb8d78
Content-Type: text/plain; charset=ISO-8859-1

[see below]

On Wed, Nov 21, 2012 at 6:39 AM, Laruence <laruence@php.net> wrote:

> Hey:
>
>    This problem come out when I was figuring a performance issue of
> Yaf_Loader.
>
>    Yaf provides a autoloader like PSR0,  when doing a classes
> autoloading. it used to:
>
>    1. stat the file,  if file does not exists,  return
>    2. zend_compile_file
>
>    this is okey when you  run yaf without opcode cache.
>
>    but when you run yaf with opcode cache,  the first stat syscall
> become a little waste.
>

You should just use  virtual_realpath() or tsrm_realpath() instead of
stat(). They must utilise realpath cache and avoid stat() calls.

Thanks. Dmitry.


>    since opcode cache always hook the zend_compile_file, and compile
> the file from cache.
>
>    so,  I changed the autoload to:
>
>     1. zend_compile_file
>     2. if compile failed, then return.
>
>    but,  zend_compile_file will throw warning if the file doesn't
> exists via zend_message_dispatcher_p
>
>    so if zend_message_dispatcher_p is ZEND_API, then I can avoid using
> such mess codes:
> https://github.com/laruence/php-yaf/blob/master/yaf_loader.c#L377
>
>    what do you think?
>
>
> thanks
> --
> Laruence  Xinchen Hui
> http://www.laruence.com/
>

--e89a8fb1f8045470a204cefb8d78--