Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:64006
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain roshambo.org from 209.85.220.42 cause and error)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=iso-8859-1
In-Reply-To: <CAF+90c8o9Vpqk4jz7kTPYycio_p-v+ck8v_Sr786G7Ud0xuL7A@mail.gmail.com>
Date: Tue, 20 Nov 2012 21:38:12 -0800
Cc: Sherif Ramadan <theanomaly.is@gmail.com>,
 Ferenc Kovacs <tyra3l@gmail.com>,
 PHP Developers Mailing List <internals@lists.php.net>
Content-Transfer-Encoding: 7bit
Message-ID: <F2DF6FC7-E254-4B0F-9136-5AAF050E9B9C@roshambo.org>
References: <23CB37F5-E956-4A5C-8ECC-7CF347A9086C@roshambo.org> <CAL+t6cF=2=vzfe2orVWo4NZ8N0akFfBOSKRdQg7nWBmTjphzsA@mail.gmail.com> <CAH-PCH5GOOt8LG70Anja3WDfWd5CHeJxZyScZD0WWMB2CEBZfg@mail.gmail.com> <CAL+t6cF+YEGb40dkV+FQZmDrLkT5PEMyQT2MEC=3uW83onbFBw@mail.gmail.com> <CAF+90c_ATMm_cJu_Ed4Rfn9_McVA=MtKun-LG+MZbqq8c_arUg@mail.gmail.com> <CAL+t6cFDZQEdOTr5G-1GZ6NAM-U6gphzt+42y6MhhmMKLxP8pg@mail.gmail.com> <CAF+90c8o9Vpqk4jz7kTPYycio_p-v+ck8v_Sr786G7Ud0xuL7A@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Subject: Re: [PHP-DEV] Where did the _logo_ functions go?
From: philip@roshambo.org (Philip Olson)


Thanks everyone, I didn't remember thinking about this so was 
impulsively curious. Dug a little now, so here's what happened:
 
  Proposal to internals (July 14, 2012) with discussion July 14-18:
  ------------------
    Thread: http://markmail.org/thread/kewdoz3dowrr7rfv

    Summary:    Seemed okay, discussed more "how" than "why", and 
                more "yes" than "maybe" approved. 
    Conclusion: No clear decision was reached.

  The patch: 
  ------------------
    Patch: https://github.com/php/php-src/pull/132
    Pull:  http://git.php.net/?p=php-src.git;a=commitdiff;h=c9eb641

    Summary:    Mostly a technical/patch related discussion there, 
                several tweaks, then pulled.
    Conclusion: Merged/pulled into master on August 4, 2012.

  What happened:
  ------------------
    - The PHP logo GUIDs were removed, and replaced with data URIs 
      in phpinfo() and friends.
    - BC: Removed four *_logo_* functions, and GUID usage.
    - E_DEPRECATED was not used beforehand, nor doc updates, they 
      were simply removed. FWIW, also no RFC.

It's understandable how a minimally used feature can be changed and 
removed without much worry/thought. But, they appear to be the only 
functions removed in 5.5, and this helps it feel even easier to not 
break BC for this not-so-important change. 

Proposal: I propose we revert this change. Future consideration might 
include E_DEPRECATED for these functions in 5.5, although I am not 
proposing that part. Seems sensible, though.

Regards,
Philip