Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63973
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50A9B0E0.7040508@sugarcrm.com>
References: <CAF+90c-CwaazdE8hNLsoLJVVU_24r5Drv9f=aNBKHFp-QuywJQ@mail.gmail.com>
	<50A9B0E0.7040508@sugarcrm.com>
Date: Mon, 19 Nov 2012 16:25:17 +0100
Message-ID: <CAF+90c_469p8HQzGPJp5sBWtDRLPWS9DVh_UCnGzMUxM0Jrt5A@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec554df408cac8e04cedab9c4
Subject: Re: [PHP-DEV] Functions for getting long / double from zval with casts
From: nikita.ppv@gmail.com (Nikita Popov)

--bcaec554df408cac8e04cedab9c4
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Nov 19, 2012 at 5:09 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> > Hi internals!
> >
> > It happens quite often that you need to extract an integer from a zval
> and
> > you also want it to work for integers in strings, etc. In order to do so
> > you currently have to cast the zval to integer. This is always rather
> > complicated because you often don't want to actually change the passed
>
> Where it happens quite often outside of function arguments (where it is
> covered by parameter parsing APIs)?
>

It's just something that crops up every now and again. E.g. when you take
it from an array or something like that.


> Should it handle all conversions the engine performs or only from string?
>

Should be the normal casting behavior.


> We could probably expose zendi_convert_to_long() and similar ones, but
> I'm not sure what the use case for these would be. Could you give more
> background on this?
>

zendi_convert_to_long() isn't really what I'm looking for. All the current
convert functions convert a zval, which is not what you normally need, at
least that's the feeling that I got. So what you end up doing is something
like this:

     long result;
     Z_ADDREF_P(zval);
     convert_to_long_ex(&zval);
     result = Z_LVAL_P(zval);
     zval_ptr_dtor(&zval);

Which seems overly complicated to me. What I'm looking for is something
like this:

    long result = zval_get_long_with_cast(zval);

Or maybe I'm missing something about how to easily get an integer from a
value?

Nikita

--bcaec554df408cac8e04cedab9c4--