Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63941
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH5GOOt8LG70Anja3WDfWd5CHeJxZyScZD0WWMB2CEBZfg@mail.gmail.com>
References: <23CB37F5-E956-4A5C-8ECC-7CF347A9086C@roshambo.org>
	<CAL+t6cF=2=vzfe2orVWo4NZ8N0akFfBOSKRdQg7nWBmTjphzsA@mail.gmail.com>
	<CAH-PCH5GOOt8LG70Anja3WDfWd5CHeJxZyScZD0WWMB2CEBZfg@mail.gmail.com>
Date: Fri, 16 Nov 2012 16:38:05 -0500
Message-ID: <CAL+t6cF+YEGb40dkV+FQZmDrLkT5PEMyQT2MEC=3uW83onbFBw@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Philip Olson <philip@roshambo.org>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Where did the _logo_ functions go?
From: theanomaly.is@gmail.com (Sherif Ramadan)

On Fri, Nov 16, 2012 at 6:10 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>
>
>
> On Fri, Nov 16, 2012 at 3:31 AM, Sherif Ramadan <theanomaly.is@gmail.com>
> wrote:
>>
>> On Thu, Nov 15, 2012 at 8:26 PM, Philip Olson <philip@roshambo.org> wrot=
e:
>> > Hello geeks,
>> >
>> > Why does PHP 5.5 remove the *_logo_* functions? Is this a security
>> > related move? Shouldn't these emit E_DEPRECATED errors in 5.5?
>> >
>> > Regards,
>> > Philip
>> >
>> > --
>> > PHP Internals - PHP Runtime Development Mailing List
>> > To unsubscribe, visit: http://www.php.net/unsub.php
>> >
>>
>> Because the guids were removed. They were replaced with data URIs. It
>> would make sense if there was some function to expose those data URIs
>> to user-land, in the same way that the *_guid functions did, but I
>> guess there isn't.
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
> it was removed when https://github.com/php/php-src/pull/132 got merged af=
ter
> a brief vote on the internals mailing list.
> see Stas concerns about reusing the same function names for getting the d=
ata
> urls: http://www.mail-archive.com/internals@lists.php.net/msg59293.html
>
> --
> Ferenc Kov=E1cs
> @Tyr43l - http://tyrael.hu


Obviously it doesn't make sense to use the same function names for the
data uris, but why weren't new functions added to expose the data uris
to userspace in the same way we used to expose the guids to userspace?

It only seems to make sense that we'd continue to do that and it's
such a simple fix to replace the functions with new ones. I honestly
don't care too much about this particular feature myself, but it
sounds pretty silly that this PR did not include the new functions for
exposing the uris.

My 0.00002 cents...