Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63845
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.219.42 as permitted sender)
MIME-Version: 1.0
Sender: adam@adamharvey.name
In-Reply-To: <CAAyV7nFOGa7UVALSQyAs-A+R0kuEmXoHPrxvCXNBnzAxLy0dww@mail.gmail.com>
References: <CADajX4CYZdNpgQv46m_6J7tQLBc=h6HxCn-bGpxr3Ou2VaqgBg@mail.gmail.com>
 <50A10A9D.9070402@oracle.com> <CAAyV7nF2tt6HtFZKevH_2kknqOvEmLJjEOF2_Bn_VHaZFUJERw@mail.gmail.com>
 <CAPwsocH3_qHSZbLFe27qX+KgBAC1D8KhwLi+PLHW503sCTBtTw@mail.gmail.com>
 <50A1946F.8010407@lerdorf.com> <50A20CCB.8090909@lsces.co.uk>
 <8A8A29F9E43E417FB5450D63019B2DDB@NeiRoze> <8f4231fc-6e3c-4a33-af71-2af5e7a95dfd@email.android.com>
 <CAAyV7nFOGa7UVALSQyAs-A+R0kuEmXoHPrxvCXNBnzAxLy0dww@mail.gmail.com>
Date: Wed, 14 Nov 2012 00:17:51 +0800
Message-ID: <CADajX4DAoHvnT2u4TPydh+=X7JKU4zUJSY9SQfGVdObQhwfJvg@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC: ext/mysql deprecation
From: aharvey@php.net (Adam Harvey)

On 14 November 2012 00:07, Anthony Ferrara <ircmaxell@gmail.com> wrote:
> There's one important thing that I think you all are missing here. You ke=
ep
> bringing up that we should just use the normal "deprecation" process. The
> problem is that the deprecation process was never designed for a feature
> like this.

Serious question: what was it designed for, then? This (along with
magic quotes, and register globals) was always what I had in the back
of my mind when it was being discussed.

<snip>
> Now, look at ext/mysql. The landscape is completely different. Major
> projects still rely on it in their most recent versions. Wordpress's late=
st
> trunk uses ext/mysql. And as was said here, it's not a trivial change to
> switch from mysql to mysqli or PDO. ext/mysql is still very heavily relie=
d
> upon.

Last time I checked, WordPress's trunk also emulated magic quotes. Old
code is old. With all due respect to the WP developers, they've made a
very deliberate choice to maintain extreme backward compatibility
because their plugin ecosystem demands it. Ultimately, they'll
presumably emulate mysql_* in userland if it's that important to them,
just as they are with magic quotes.

I don't think we should let that stop us from removing dead code, or
replacing APIs that promote antipatterns.

> What I would suggest, is not adding E_DEPRECATED for 5.5. Instead,
> officially deprecate it in the docs. Then start a PR campaign to get
> projects like WP to switch away from it. Get the word out there as much a=
s
> possible. Then in 1 to 2 years when 5.6/6 is released, add E_DEPRECATED.

It's already deprecated in the documentation, really=C2=A0=E2=80=94 I doubt=
 adding
the actual word "deprecated" will make a difference.

If we're going to drag this out, I'd rather spend an extra year with
PHP actually generating warnings, as I said upthread.

Adam