Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:63734 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8716 invoked from network); 1 Nov 2012 01:40:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Nov 2012 01:40:37 -0000 Authentication-Results: pb1.pair.com header.from=adam@adamharvey.name; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=adam@adamharvey.name; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.214.170 as permitted sender) X-PHP-List-Original-Sender: adam@adamharvey.name X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:57205] helo=mail-ob0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 55/30-06355-D03D1905 for ; Wed, 31 Oct 2012 20:40:29 -0500 Received: by mail-ob0-f170.google.com with SMTP id ni5so2202033obc.29 for ; Wed, 31 Oct 2012 18:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamharvey.name; s=google; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=7LvHXLgY9LJt5NAvpBtxNcozcQ92PM2TrIRd4Xlg2fw=; b=MML9q6+itq3NQU2GnxnOVE3xmN1qh3EU53ODH9lFOpgCJhE/1Fs0d+9bWl5+P6/LpD R3/4hyyoJbpi/enGExv0Wu+Tb1h7beMbMzf7QGsAjrV3xPRt+bAz+Wpt4S4y6f2ufmco 6mmyoBkPnEHzQYLwGy7mQ/e4oweFB7cWlb+bg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=7LvHXLgY9LJt5NAvpBtxNcozcQ92PM2TrIRd4Xlg2fw=; b=UiApokglr+//+IhS5ASs8Z5ZcgT7icr9ZG+EHGTyWXvzsNcegk/R2D3Lzp3R8Q/FTI oJ6q0Vey/Z74yoH47uzL4vjFZa50QlURXBQGvRnga2R+2ROAz/RWOlOcUhUIiuJxONwY 5d+x0wU1gibOzjM1E/sU9YcEHH00nzxwzJq5dc9/znv4YFCd9+G6by+7QnyFryBJnCPs BRchRob7tCp/IR/vwuEwwDq3xWM7CQp2Aa7WnAUSpVVmL/k2g4t8VTnoNT8iFxmjXBYG rJW9GXwahujJTAaQmLa6hMyg0sUfp0jJBL0qCkxzUeqhUsnRAlyWWYfBoG+CEsN/UUf0 cfOw== Received: by 10.60.28.234 with SMTP id e10mr33838168oeh.67.1351734027006; Wed, 31 Oct 2012 18:40:27 -0700 (PDT) MIME-Version: 1.0 Sender: adam@adamharvey.name Received: by 10.76.123.75 with HTTP; Wed, 31 Oct 2012 18:40:06 -0700 (PDT) In-Reply-To: References: <509006DA.6030200@sugarcrm.com> Date: Thu, 1 Nov 2012 09:40:06 +0800 X-Google-Sender-Auth: kJXdRVs_gWo8isUBGlHp9qzLeM4 Message-ID: To: Sara Golemon Cc: PHP internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQl1jGQ2GVkj0lOjpSAc3OwwFhEZEu4BG5uzs929kXJg/j2zrM2CWzNq+9LrB11r17z2ZZu9 Subject: Re: [PHP-DEV] [RFC] ICU UConverter implementation for ext/intl From: aharvey@php.net (Adam Harvey) On 31 October 2012 06:18, Sara Golemon wrote: > With the exception of renaming the UConverter::UCNV_* constants to > remove the UCNV_ prefix, I believe I've addressed the concerns thus > far. ((Waiting to hear if anyone else wants to weigh in on the > contants)) The RFC has been updated accordingly.+ I would say that unprefixing makes sense in general, particularly since that's what happens in other intl classes (such as Collator). Prefixing the callback reason constants with REASON_* seems like a good compromise there =E2=80=94 as you said upthread, they are different to the other constants defined on UConverter. Beyond that, I think the type constants would do fine as direct UConverter constants (UConverter::UTF8, for instance, makes sense to me =E2=80=94 in general, you're using a converter because you want to deal with encoding types). I'm +1 on the functionality in general. The thought of another encoding conversion API in PHP doesn't fill me with great joy given we already have mbstring and iconv, but it does provide features neither of those libraries provide: combined with the existing intl functionality and the ever-increasing need for internationalisation support, I'd like to think we might look at nudging intl towards being the usual way of providing that functionality in PHP. Thanks, Adam, who is apparently in a run-on sentence kind of mood today.