Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63728
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zerocue.com designates 67.200.53.250 as permitted sender)
Message-ID: <50909CDF.9090505@zerocue.com>
Date: Tue, 30 Oct 2012 22:37:03 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>
CC: Pierre Joye <pierre.php@gmail.com>, 
 "internals@lists.php.net" <internals@lists.php.net>
References: <508A68B9.1050801@zerocue.com> <508AA48D.5010903@sugarcrm.com> <508C1C4F.6060406@zerocue.com> <CAEZPtU51k7zULCoHvk=vJEPTM+qHtDpgE=jPKQDQa5EZ6NgnbA@mail.gmail.com> <508D5726.8080200@zerocue.com> <508ED5A4.9010100@sugarcrm.com>
In-Reply-To: <508ED5A4.9010100@sugarcrm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Property Accessors v1.2 : isset / unset "failable"
From: cpriest@zerocue.com (Clint Priest)

Would you say the same of unset?  Always benign?


On 10/29/2012 2:14 PM, Stas Malyshev wrote:
> Hi!
>
>> So... to be explicit here, you think in this situation:
>>
>> class a {
>>     public $b {
>>        set($x) { $this->b = $x; }
>>     }
>> }
>>
>> $o = new a();
>>
>> if(!isset($o->b)) {
>>     /* delete files */
>> }
>> echo (int)isset($o->b);  /* This should return false and not emit any
>> sort of warning/notice? */
> isset should return false, since $b is not set value. It should not
> produce any warning. Of course (int) would produce 0 then ;)
>
>> I mean specifically, there is no getter defined, therefore the result
>> if isset is indeterminate and while I can see it not causing execution
> No, the result is determinate - it's false. That's the point of isset()
> in PHP and that's how it is used in existing code.
>
>> to stop I don't see it being a good idea to not warn the developer that
>> what they've attempted is not correct.  Without a getter, isset() is
>> not a legal call (since the value cannot be retrieved).
> isset() should always be legal. This is the way to check if $o->b is legal.
>
>

-- 
-Clint