Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63711
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVrJZ0-FQPMdZUD+5QE2nrZGZFqXpcVP4ftkZQXewY1iHQ@mail.gmail.com>
References: <CAESVnVrJZ0-FQPMdZUD+5QE2nrZGZFqXpcVP4ftkZQXewY1iHQ@mail.gmail.com>
Date: Tue, 30 Oct 2012 07:27:37 +0100
Message-ID: <CAEZPtU6JQKSvh9b=QMmYfvPJWP-ZdMBOX9bd8J9=ytHu1gz_=Q@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] ICU UConverter implementation for ext/intl
From: pierre.php@gmail.com (Pierre Joye)

hi Sara!

On Tue, Oct 30, 2012 at 2:57 AM, Sara Golemon <pollita@php.net> wrote:
> http://wiki.php.net/rfc/uconverter
>
> Discuss!

Nice job!

Some comments, raw :) :

- the UCNV prefix is not necessary, we are in the UConverter class
already, I would simply use LATIN_1, or ILLEGAL for exampe.
- It is OO, we should or could use exception. Warning are not nice to
deal with and errors are quite common during conversion
- I would add ERROR_ to the error related constants (UNASSIGNED & co), or?

Some questions, is 'latin1' the same than const UCNV_LATIN_1? or is
there any relation between the two?

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org