Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63692
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zerocue.com designates 67.200.53.250 as permitted sender)
Message-ID: <508D5726.8080200@zerocue.com>
Date: Sun, 28 Oct 2012 11:02:46 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Pierre Joye <pierre.php@gmail.com>
CC: internals@lists.php.net
References: <508A68B9.1050801@zerocue.com> <508AA48D.5010903@sugarcrm.com> <508C1C4F.6060406@zerocue.com> <CAEZPtU51k7zULCoHvk=vJEPTM+qHtDpgE=jPKQDQa5EZ6NgnbA@mail.gmail.com>
In-Reply-To: <CAEZPtU51k7zULCoHvk=vJEPTM+qHtDpgE=jPKQDQa5EZ6NgnbA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Property Accessors v1.2 : isset / unset "failable"
From: cpriest@zerocue.com (Clint Priest)

So... to be explicit here, you think in this situation:

class a {
   public $b {
      set($x) { $this->b = $x; }
   }
}

$o = new a();

if(!isset($o->b)) {
   /* delete files */
}
echo (int)isset($o->b);  /* This should return false and not emit any 
sort of warning/notice? */

I mean specifically, there is no getter defined, therefore the result 
if isset is indeterminate and while I can see it not causing execution 
to stop I don't see it being a good idea to not warn the developer that 
what they've attempted is not correct.  Without a getter, isset() is 
not a legal call (since the value cannot be retrieved).

On Sunday, October 28, 2012 4:02:23 AM, Pierre Joye wrote:
> hi Clint,
>
> On Sat, Oct 27, 2012 at 7:39 PM, Clint Priest <cpriest@zerocue.com> wrote:
>> That's basically what #2 is getting at, my only question is, emit a warning
>> or notice or not?
>>
>> Technically returning false on an invalid isset() call could be misleading
>> without emitting some kind of notice or warning about it.
>
> isset is used for this exact purpose, avoid noisy scripts while
> testing the existence (instance, init'ed, etc.) of a variable or
> property. Raising a notice here sounds wrong, no matter in which
> context.
>
> Cheers,

--
-Clint