Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6368 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52751 invoked by uid 1010); 12 Dec 2003 19:31:39 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 52623 invoked from network); 12 Dec 2003 19:31:37 -0000 Received: from unknown (HELO asuka.nerv) (24.112.18.98) by pb1.pair.com with SMTP; 12 Dec 2003 19:31:37 -0000 Received: (qmail 4187 invoked from network); 12 Dec 2003 14:26:50 -0000 Received: from rei.nerv (HELO dummy.com) (rei@192.168.1.1) by asuka.nerv with SMTP; 12 Dec 2003 14:26:50 -0000 Reply-To: ilia@prohost.org Organization: Prohost.org To: Rasmus Lerdorf , Moriyoshi Koizumi , PHP Internals Date: Fri, 12 Dec 2003 14:42:54 -0500 User-Agent: KMail/1.5.4 References: <25BBBBC2-2CD2-11D8-8FCC-000A95CE0C62@at.wakwak.com> <200312121407.48578.ilia@prohost.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200312121442.54406.ilia@prohost.org> Subject: Re: [PHP-DEV] Re: Regarding the latest patch on fgetcsv() (stable branch) From: ilia@prohost.org (Ilia Alshanetsky) On December 12, 2003 02:02 pm, Rasmus Lerdorf wrote: > I agree that it would be a good idea to provide a mechanism to do that, > but at this point I don't think we should be changing the behaviour of > fgetcsv() in neither the stable branch nor the HEAD branch. I'd add a new > binary-safe version of the function instead for this. Or an optional arg, > but fgetcsv() already has 2 optional args. I think we could add another optional argument (bitmask) that could be used to control various capabilities of fgetcsv(). So, if another tuneable behavior is necessary it could be easily added without breaking BC. On a related note I should mention that fgetcsv() in 4.3.X is currently 2.5 times faster then it's equivalent in 5.X. Ilia